Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:52434
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.215.170 as permitted sender)
DomainKey-Status: bad
DomainKey-Signature: a=rsa-sha1; c=nofws;
        d=gmail.com; s=gamma;
        h=mime-version:sender:in-reply-to:references:date
         :x-google-sender-auth:message-id:subject:from:to:cc:content-type;
        b=dap6hJ9LuwNGlcv1FnrIiDCxi/h/s6jXr8dhiFksQeBvI257f8xFNj32R3/GGSR0j3
         J0RZE7GnpodpWyckMS8jGCvfEcgQhltLCC3P+sNXxUg8G6PEs84QbZZd5qDDM8STy6FG
         wBuL0ilgUzD+3sMXhZGGZBs2cABTNoIvic8gw=
MIME-Version: 1.0
Sender: tyra3l@gmail.com
In-Reply-To: <8757232E56758B42B2EE4F9D2CA019C901418DCB@US-EX2.zend.net>
References: <BANLkTimOZPjAu_mJSctXPL3x41QUekFtkw@mail.gmail.com>
	<BANLkTimUN1fqfZGai6cYG7sK=HHYFh72fw@mail.gmail.com>
	<8757232E56758B42B2EE4F9D2CA019C901418DCB@US-EX2.zend.net>
Date: Tue, 17 May 2011 18:31:33 +0200
Message-ID: <BANLkTi=XkP4W6_hVojcL8E7HSnRsVw70+g@mail.gmail.com>
To: Andi Gutmans <andi@zend.com>
Cc: Felipe Pena <felipensp@gmail.com>, internals <internals@lists.php.net>
Content-Type: multipart/alternative; boundary=0016e65b52f822540104a37b4e3c
Subject: Re: [PHP-DEV] Re: [RFC] Improved parser error message
From: info@tyrael.hu (Ferenc Kovacs)

--0016e65b52f822540104a37b4e3c
Content-Type: text/plain; charset=UTF-8

On Tue, May 17, 2011 at 6:01 PM, Andi Gutmans <andi@zend.com> wrote:

> Hi Felipe,
>
> Read the archives. We discussed T_PAAMAYIM_NEKUDOTAYIM extensively and
> agreed to keep it as a historical landmark. Let's not have the discussion
> yet again within the same year. Google it just to see the # of mentions.
>
>
Maybe you don't remember, but Felipe participated in that discussion, to be
exact he proposed this exact feature there:
http://www.mail-archive.com/internals@lists.php.net/msg48173.html
after Felipe's mail, nobody objected about replacing the constants with
meaningful names, as it was the original idea, but nobody found a clean way
to implement it before.


> What we could do as a compromise between history and improving many of the
> parse error messages is:
> Parse error: syntax error, unexpected :: (T_PAAMAYIM_NEKUDOTAYIM) in
> Command line code on line 1
>
>
maybe it's a little bit redundant, but it can be a good transition.


> Generally speaking I'm OK with the other changes but I don't know if any
> extensions or scripts depend on them (probably not).
> I suggest to give it another couple of days to see if anyone has any valid
> concerns on breakage this could cause.
>
>
as Felipe mentioned, his patch doesn't modify the token names(so the token_
functions aren't affected by this change), only the rendering of the error
messages.

Tyrael

--0016e65b52f822540104a37b4e3c--