Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:52430
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.160.170 as permitted sender)
DomainKey-Status: bad
DomainKey-Signature: a=rsa-sha1; c=nofws;
        d=gmail.com; s=gamma;
        h=mime-version:in-reply-to:references:from:date:message-id:subject:to
         :cc:content-type;
        b=t9e+FL3ByXBmcQYlXzJZ8URScV8GcS2704ReQIROFPQyZ497dyalp9JLAc0KW9OVcz
         BoNR5DwjxdXLrnU3q9FL0c2RVTPz7MNNumE1uFlxYOpRKR+fUzbcBtu765r26xiYV+1l
         EJZupnsARu2SCs2JNWS0oDsJQR9XewVvTkoFA=
MIME-Version: 1.0
In-Reply-To: <op.vvmp6xm9idpuyk@clk-0081.clk-domain>
References: <BANLkTinNZmE9NszP4nqeGpx3ox0eBWx6RA@mail.gmail.com> <op.vvmp6xm9idpuyk@clk-0081.clk-domain>
Date: Tue, 17 May 2011 20:02:19 +0500
Message-ID: <BANLkTincengUnyU4Zz6i0e_hM+WHKufykg@mail.gmail.com>
To: Gustavo Lopes <glopes@nebm.ist.utl.pt>
Cc: internals@lists.php.net
Content-Type: text/plain; charset=UTF-8
Subject: Re: [PHP-DEV] Need karma for committing test patches
From: confik@gmail.com (Alexey Shein)

> A few remarks:
>
> * Isn't this supposed to be fixed? Was there something that triggered a
> regression?

As far as I can see Jani checked only case when already closed file
descriptor was passed to curl_setopt. Here's the check is performed in
curl_exec, i.e. in curl_setopt file descriptor was valid and at the
moment of call curl_setopt it's closed/invalid.

> * If this strategy is used (checking whether the resource associated with
> the stored zval is valid), how about curl_multi_exec?

The logic is simple - if resource is ok, then go with it, else it's
changed to default stderr. Did not tested it on curl_multi_exec(),
just took the failed phpt file and got it working :)

> * I think a better strategy would be to just dup the file descriptor gotten
> after the cast in curl_setopt, store it (instead of storing the zval) and
> close it on curl handle destruction. This way we wouldn't have to worry
> about zval refcounts or whether the file descriptor obtained is still valid.
> Could you see if this other strategy works? (otherwise I can do it later
> this week)

Yes, I like your strategy, will try to do it. Also I would be happy if
somebody could answer my questions because "all documentation is
written in C" is not so easy to understand :)

> --
> Gustavo Lopes
>
> --
> PHP Internals - PHP Runtime Development Mailing List
> To unsubscribe, visit: http://www.php.net/unsub.php
>
>



-- 
Regards,
Shein Alexey