Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:52423 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 85567 invoked from network); 17 May 2011 13:41:38 -0000 Received: from unknown (HELO lists.php.net) (127.0.0.1) by localhost with SMTP; 17 May 2011 13:41:38 -0000 Authentication-Results: pb1.pair.com header.from=confik@gmail.com; sender-id=pass; domainkeys=bad Authentication-Results: pb1.pair.com smtp.mail=confik@gmail.com; spf=pass; sender-id=pass Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.218.42 as permitted sender) DomainKey-Status: bad X-DomainKeys: Ecelerity dk_validate implementing draft-delany-domainkeys-base-01 X-PHP-List-Original-Sender: confik@gmail.com X-Host-Fingerprint: 209.85.218.42 mail-yi0-f42.google.com Received: from [209.85.218.42] ([209.85.218.42:36942] helo=mail-yi0-f42.google.com) by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP id C6/24-61142-11B72DD4 for ; Tue, 17 May 2011 09:41:37 -0400 Received: by yib12 with SMTP id 12so165835yib.29 for ; Tue, 17 May 2011 06:41:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:from:date:message-id:subject:to :content-type; bh=UX1IDkZFQjc3WwbBAA3n2QQZUAqbVOKSFFg5Gqv4/Uc=; b=w8Nk4/7sRA5jruRW3r241yuGdaVPcW3uZARYW49Vbkdt0Hu7eThM4Giu0Ec/UMJqRs F1NUxSEM2e8iPh8uKvliGEwLLUNk44mEW5g82cNZa10u7IVxTKYvzrbLgHfxd4gVXgeI 5mT05l4lFTiiBQUN0cu4CTAYtpOF366WswyQw= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:from:date:message-id:subject:to:content-type; b=tKX5Wpwr0J+6plg4Xrz90y2ErZEj4avSy2aYxC5xy8fjIcQSc60Ukfv9QbHDndSMv4 r8bVffxDtvGKhopnJ0SAtBQEGQKgcdPhTtr9lIPc6SRyBPBa5dmuyI3SJS3nT1QXL8M3 Lv9ouqlaAeo2huuDdBHCDm19KM+vPmIfrFG24= Received: by 10.90.139.11 with SMTP id m11mr457097agd.70.1305639673189; Tue, 17 May 2011 06:41:13 -0700 (PDT) MIME-Version: 1.0 Received: by 10.90.90.2 with HTTP; Tue, 17 May 2011 06:40:53 -0700 (PDT) Date: Tue, 17 May 2011 18:40:53 +0500 Message-ID: To: PHP Internals Content-Type: multipart/mixed; boundary=00163630ef57ecd69504a378ec8d Subject: [PHP-DEV] Need karma for committing test patches From: confik@gmail.com (Alexey Shein) --00163630ef57ecd69504a378ec8d Content-Type: text/plain; charset=UTF-8 I need karma to commit test fixes: 1) session_encode_basic - added serialize_precision=100 ini setting 2) fix for http://bugs.php.net/48203: there's a segfault when CURLOPT_STDERR file pointer is closed before calling curl_exec, i.e. like this: $fp = fopen(dirname(__FILE__) . '/bug48203.tmp', 'w'); $ch = curl_init(); curl_setopt($ch, CURLOPT_VERBOSE, 1); curl_setopt($ch, CURLOPT_STDERR, $fp); curl_setopt($ch, CURLOPT_URL, getenv("PHP_CURL_HTTP_REMOTE_SERVER")); fclose($fp); // <-- premature close of $fp caused a crash! curl_exec($ch); // segfault All tests run ok on php5.3 php5.4 and trunk. Could somebody review this patch since I'm new to developing php and could make some silly mistakes? I already have an account: shein -- Regards, Shein Alexey --00163630ef57ecd69504a378ec8d Content-Type: text/plain; charset=US-ASCII; name="fix-bug48203.patch.txt" Content-Disposition: attachment; filename="fix-bug48203.patch.txt" Content-Transfer-Encoding: base64 X-Attachment-Id: f_gnsvowkd0 SW5kZXg6IHRydW5rL2V4dC9jdXJsL2ludGVyZmFjZS5jCj09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIHRydW5rL2V4 dC9jdXJsL2ludGVyZmFjZS5jCShyZXZpc2lvbiAzMTExMjEpCisrKyB0cnVuay9leHQvY3VybC9p bnRlcmZhY2UuYwkod29ya2luZyBjb3B5KQpAQCAtMjIwNCw2ICsyMjA0LDE2IEBACiAKIAlaRU5E X0ZFVENIX1JFU09VUkNFKGNoLCBwaHBfY3VybCAqLCAmemlkLCAtMSwgbGVfY3VybF9uYW1lLCBs ZV9jdXJsKTsKIAorCS8vIGNoZWNrIGlmIGN1c3RvbSBzdGRfZXJyIGlzIG5vdCBhbHJlYWR5IGNs b3NlZAorCWlmIChjaC0+aGFuZGxlcnMtPnN0ZF9lcnIpIHsKKwkJcGhwX3N0cmVhbSAqc3RyZWFt OworCisJICAgIGlmICghKHBocF9zdHJlYW1fZnJvbV96dmFsX25vX3ZlcmlmeShzdHJlYW0sICZj aC0+aGFuZGxlcnMtPnN0ZF9lcnIpKSkgeworCSAgICAgICAgcGhwX2Vycm9yX2RvY3JlZihOVUxM IFRTUk1MU19DQywgRV9XQVJOSU5HLCAiU1RERVJSIGZpbGUgaGFuZGxlIGlzIGluY29ycmVjdCIp OworCSAgICAgICAgY3VybF9lYXN5X3NldG9wdChjaC0+Y3AsIENVUkxPUFRfU1RERVJSLCBzdGRl cnIpOworCSAgICB9CisJfQorCiAJX3BocF9jdXJsX2NsZWFudXBfaGFuZGxlKGNoKTsKIAogCWVy cm9yID0gY3VybF9lYXN5X3BlcmZvcm0oY2gtPmNwKTsKSW5kZXg6IHRydW5rL2V4dC9jdXJsL3Rl c3RzL2J1ZzQ4MjAzLnBocHQKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gdHJ1bmsvZXh0L2N1cmwvdGVzdHMvYnVn NDgyMDMucGhwdAkocmV2aXNpb24gMzExMTIxKQorKysgdHJ1bmsvZXh0L2N1cmwvdGVzdHMvYnVn NDgyMDMucGhwdAkod29ya2luZyBjb3B5KQpAQCAtMTgsMTYgKzE4LDIzIEBACiAKIGN1cmxfc2V0 b3B0KCRjaCwgQ1VSTE9QVF9WRVJCT1NFLCAxKTsKIGN1cmxfc2V0b3B0KCRjaCwgQ1VSTE9QVF9T VERFUlIsICRmcCk7Ci1jdXJsX3NldG9wdCgkY2gsIENVUkxPUFRfVVJMLCAiIik7CitjdXJsX3Nl dG9wdCgkY2gsIENVUkxPUFRfVVJMLCBnZXRlbnYoIlBIUF9DVVJMX0hUVFBfUkVNT1RFX1NFUlZF UiIpKTsKIAogZmNsb3NlKCRmcCk7IC8vIDwtLSBwcmVtYXR1cmUgY2xvc2Ugb2YgJGZwIGNhdXNl ZCBhIGNyYXNoIQogCiBjdXJsX2V4ZWMoJGNoKTsKIAorY3VybF9jbG9zZSgkY2gpOworCiBlY2hv ICJPa1xuIjsKIAogPz4KIC0tQ0xFQU4tLQogPD9waHAgQHVubGluayhkaXJuYW1lKF9fRklMRV9f KSAuICcvYnVnNDgyMDMudG1wJyk7ID8+Ci0tLUVYUEVDVC0tCistLUVYUEVDVEYtLQorV2Fybmlu ZzogY3VybF9leGVjKCk6ICVkIGlzIG5vdCBhIHZhbGlkIHN0cmVhbSByZXNvdXJjZSBpbiAlcyBv biBsaW5lICVkCisKK1dhcm5pbmc6IGN1cmxfZXhlYygpOiBTVERFUlIgZmlsZSBoYW5kbGUgaXMg aW5jb3JyZWN0IGluICVzIG9uIGxpbmUgJWQKKyogQWJvdXQgdG8gY29ubmVjdCgpICVhCisqIENs b3NpbmcgY29ubmVjdGlvbiAjMAogT2sKSW5kZXg6IGJyYW5jaGVzL1BIUF81XzMvZXh0L2N1cmwv aW50ZXJmYWNlLmMKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PQotLS0gYnJhbmNoZXMvUEhQXzVfMy9leHQvY3VybC9pbnRl cmZhY2UuYwkocmV2aXNpb24gMzExMTMyKQorKysgYnJhbmNoZXMvUEhQXzVfMy9leHQvY3VybC9p bnRlcmZhY2UuYwkod29ya2luZyBjb3B5KQpAQCAtMjIwOCw2ICsyMjA4LDE2IEBACiAKIAlaRU5E X0ZFVENIX1JFU09VUkNFKGNoLCBwaHBfY3VybCAqLCAmemlkLCAtMSwgbGVfY3VybF9uYW1lLCBs ZV9jdXJsKTsKIAorCS8vIGNoZWNrIGlmIGN1c3RvbSBzdGRfZXJyIGlzIG5vdCBhbHJlYWR5IGNs b3NlZAorCWlmIChjaC0+aGFuZGxlcnMtPnN0ZF9lcnIpIHsKKwkJcGhwX3N0cmVhbSAqc3RyZWFt OworCisJICAgIGlmICghKHBocF9zdHJlYW1fZnJvbV96dmFsX25vX3ZlcmlmeShzdHJlYW0sICZj aC0+aGFuZGxlcnMtPnN0ZF9lcnIpKSkgeworCSAgICAgICAgcGhwX2Vycm9yX2RvY3JlZihOVUxM IFRTUk1MU19DQywgRV9XQVJOSU5HLCAiU1RERVJSIGZpbGUgaGFuZGxlIGlzIGluY29ycmVjdCIp OworCSAgICAgICAgY3VybF9lYXN5X3NldG9wdChjaC0+Y3AsIENVUkxPUFRfU1RERVJSLCBzdGRl cnIpOworCSAgICB9CisJfQorCiAJX3BocF9jdXJsX2NsZWFudXBfaGFuZGxlKGNoKTsKIAogCWVy cm9yID0gY3VybF9lYXN5X3BlcmZvcm0oY2gtPmNwKTsKSW5kZXg6IGJyYW5jaGVzL1BIUF81XzMv ZXh0L2N1cmwvdGVzdHMvYnVnNDgyMDMucGhwdAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBicmFuY2hlcy9QSFBf NV8zL2V4dC9jdXJsL3Rlc3RzL2J1ZzQ4MjAzLnBocHQJKHJldmlzaW9uIDMxMTEzMikKKysrIGJy YW5jaGVzL1BIUF81XzMvZXh0L2N1cmwvdGVzdHMvYnVnNDgyMDMucGhwdAkod29ya2luZyBjb3B5 KQpAQCAtMTgsMTYgKzE4LDIzIEBACiAKIGN1cmxfc2V0b3B0KCRjaCwgQ1VSTE9QVF9WRVJCT1NF LCAxKTsKIGN1cmxfc2V0b3B0KCRjaCwgQ1VSTE9QVF9TVERFUlIsICRmcCk7Ci1jdXJsX3NldG9w dCgkY2gsIENVUkxPUFRfVVJMLCAiIik7CitjdXJsX3NldG9wdCgkY2gsIENVUkxPUFRfVVJMLCBn ZXRlbnYoIlBIUF9DVVJMX0hUVFBfUkVNT1RFX1NFUlZFUiIpKTsKIAogZmNsb3NlKCRmcCk7IC8v IDwtLSBwcmVtYXR1cmUgY2xvc2Ugb2YgJGZwIGNhdXNlZCBhIGNyYXNoIQogCiBjdXJsX2V4ZWMo JGNoKTsKIAorY3VybF9jbG9zZSgkY2gpOworCiBlY2hvICJPa1xuIjsKIAogPz4KIC0tQ0xFQU4t LQogPD9waHAgQHVubGluayhkaXJuYW1lKF9fRklMRV9fKSAuICcvYnVnNDgyMDMudG1wJyk7ID8+ Ci0tLUVYUEVDVC0tCistLUVYUEVDVEYtLQorV2FybmluZzogY3VybF9leGVjKCk6ICVkIGlzIG5v dCBhIHZhbGlkIHN0cmVhbSByZXNvdXJjZSBpbiAlcyBvbiBsaW5lICVkCisKK1dhcm5pbmc6IGN1 cmxfZXhlYygpOiBTVERFUlIgZmlsZSBoYW5kbGUgaXMgaW5jb3JyZWN0IGluICVzIG9uIGxpbmUg JWQKKyogQWJvdXQgdG8gY29ubmVjdCgpICVhCisqIENsb3NpbmcgY29ubmVjdGlvbiAjMAogT2sK SW5kZXg6IGJyYW5jaGVzL1BIUF81XzQvZXh0L2N1cmwvaW50ZXJmYWNlLmMKPT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQot LS0gYnJhbmNoZXMvUEhQXzVfNC9leHQvY3VybC9pbnRlcmZhY2UuYwkocmV2aXNpb24gMzExMTIx KQorKysgYnJhbmNoZXMvUEhQXzVfNC9leHQvY3VybC9pbnRlcmZhY2UuYwkod29ya2luZyBjb3B5 KQpAQCAtMjIwNCw2ICsyMjA0LDE2IEBACiAKIAlaRU5EX0ZFVENIX1JFU09VUkNFKGNoLCBwaHBf Y3VybCAqLCAmemlkLCAtMSwgbGVfY3VybF9uYW1lLCBsZV9jdXJsKTsKIAorCS8vIGNoZWNrIGlm IGN1c3RvbSBzdGRfZXJyIGlzIG5vdCBhbHJlYWR5IGNsb3NlZAorCWlmIChjaC0+aGFuZGxlcnMt PnN0ZF9lcnIpIHsKKwkJcGhwX3N0cmVhbSAqc3RyZWFtOworCisJICAgIGlmICghKHBocF9zdHJl YW1fZnJvbV96dmFsX25vX3ZlcmlmeShzdHJlYW0sICZjaC0+aGFuZGxlcnMtPnN0ZF9lcnIpKSkg eworCSAgICAgICAgcGhwX2Vycm9yX2RvY3JlZihOVUxMIFRTUk1MU19DQywgRV9XQVJOSU5HLCAi U1RERVJSIGZpbGUgaGFuZGxlIGlzIGluY29ycmVjdCIpOworCSAgICAgICAgY3VybF9lYXN5X3Nl dG9wdChjaC0+Y3AsIENVUkxPUFRfU1RERVJSLCBzdGRlcnIpOworCSAgICB9CisJfQorCiAJX3Bo cF9jdXJsX2NsZWFudXBfaGFuZGxlKGNoKTsKIAogCWVycm9yID0gY3VybF9lYXN5X3BlcmZvcm0o Y2gtPmNwKTsKSW5kZXg6IGJyYW5jaGVzL1BIUF81XzQvZXh0L2N1cmwvdGVzdHMvYnVnNDgyMDMu cGhwdAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09Ci0tLSBicmFuY2hlcy9QSFBfNV80L2V4dC9jdXJsL3Rlc3RzL2J1ZzQ4 MjAzLnBocHQJKHJldmlzaW9uIDMxMTEyMSkKKysrIGJyYW5jaGVzL1BIUF81XzQvZXh0L2N1cmwv dGVzdHMvYnVnNDgyMDMucGhwdAkod29ya2luZyBjb3B5KQpAQCAtMTgsMTYgKzE4LDIzIEBACiAK IGN1cmxfc2V0b3B0KCRjaCwgQ1VSTE9QVF9WRVJCT1NFLCAxKTsKIGN1cmxfc2V0b3B0KCRjaCwg Q1VSTE9QVF9TVERFUlIsICRmcCk7Ci1jdXJsX3NldG9wdCgkY2gsIENVUkxPUFRfVVJMLCAiIik7 CitjdXJsX3NldG9wdCgkY2gsIENVUkxPUFRfVVJMLCBnZXRlbnYoIlBIUF9DVVJMX0hUVFBfUkVN T1RFX1NFUlZFUiIpKTsKIAogZmNsb3NlKCRmcCk7IC8vIDwtLSBwcmVtYXR1cmUgY2xvc2Ugb2Yg JGZwIGNhdXNlZCBhIGNyYXNoIQogCiBjdXJsX2V4ZWMoJGNoKTsKIAorY3VybF9jbG9zZSgkY2gp OworCiBlY2hvICJPa1xuIjsKIAogPz4KIC0tQ0xFQU4tLQogPD9waHAgQHVubGluayhkaXJuYW1l KF9fRklMRV9fKSAuICcvYnVnNDgyMDMudG1wJyk7ID8+Ci0tLUVYUEVDVC0tCistLUVYUEVDVEYt LQorV2FybmluZzogY3VybF9leGVjKCk6ICVkIGlzIG5vdCBhIHZhbGlkIHN0cmVhbSByZXNvdXJj ZSBpbiAlcyBvbiBsaW5lICVkCisKK1dhcm5pbmc6IGN1cmxfZXhlYygpOiBTVERFUlIgZmlsZSBo YW5kbGUgaXMgaW5jb3JyZWN0IGluICVzIG9uIGxpbmUgJWQKKyogQWJvdXQgdG8gY29ubmVjdCgp ICVhCisqIENsb3NpbmcgY29ubmVjdGlvbiAjMAogT2sK --00163630ef57ecd69504a378ec8d Content-Type: text/plain; charset=US-ASCII; name="fix-session_encode_basic.patch.txt" Content-Disposition: attachment; filename="fix-session_encode_basic.patch.txt" Content-Transfer-Encoding: base64 X-Attachment-Id: f_gnsvpfcl1 SW5kZXg6IHRydW5rL2V4dC9zZXNzaW9uL3Rlc3RzL3Nlc3Npb25fZW5jb2RlX2Jhc2ljLnBocHQK PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PQotLS0gdHJ1bmsvZXh0L3Nlc3Npb24vdGVzdHMvc2Vzc2lvbl9lbmNvZGVfYmFz aWMucGhwdAkocmV2aXNpb24gMzExMTIxKQorKysgdHJ1bmsvZXh0L3Nlc3Npb24vdGVzdHMvc2Vz c2lvbl9lbmNvZGVfYmFzaWMucGhwdAkod29ya2luZyBjb3B5KQpAQCAtMSw1ICsxLDcgQEAKIC0t VEVTVC0tCiBUZXN0IHNlc3Npb25fZW5jb2RlKCkgZnVuY3Rpb24gOiBiYXNpYyBmdW5jdGlvbmFs aXR5CistLUlOSS0tCitzZXJpYWxpemVfcHJlY2lzaW9uPTEwMAogLS1TS0lQSUYtLQogPD9waHAg aW5jbHVkZSgnc2tpcGlmLmluYycpOyA/PgogLS1GSUxFLS0KSW5kZXg6IGJyYW5jaGVzL1BIUF81 XzMvZXh0L3Nlc3Npb24vdGVzdHMvc2Vzc2lvbl9lbmNvZGVfYmFzaWMucGhwdAo9PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 Ci0tLSBicmFuY2hlcy9QSFBfNV8zL2V4dC9zZXNzaW9uL3Rlc3RzL3Nlc3Npb25fZW5jb2RlX2Jh c2ljLnBocHQJKHJldmlzaW9uIDMxMTEzMikKKysrIGJyYW5jaGVzL1BIUF81XzMvZXh0L3Nlc3Np b24vdGVzdHMvc2Vzc2lvbl9lbmNvZGVfYmFzaWMucGhwdAkod29ya2luZyBjb3B5KQpAQCAtMSw1 ICsxLDcgQEAKIC0tVEVTVC0tCiBUZXN0IHNlc3Npb25fZW5jb2RlKCkgZnVuY3Rpb24gOiBiYXNp YyBmdW5jdGlvbmFsaXR5CistLUlOSS0tCitzZXJpYWxpemVfcHJlY2lzaW9uPTEwMAogLS1TS0lQ SUYtLQogPD9waHAgaW5jbHVkZSgnc2tpcGlmLmluYycpOyA/PgogLS1GSUxFLS0KSW5kZXg6IGJy YW5jaGVzL1BIUF81XzQvZXh0L3Nlc3Npb24vdGVzdHMvc2Vzc2lvbl9lbmNvZGVfYmFzaWMucGhw dAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09Ci0tLSBicmFuY2hlcy9QSFBfNV80L2V4dC9zZXNzaW9uL3Rlc3RzL3Nlc3Np b25fZW5jb2RlX2Jhc2ljLnBocHQJKHJldmlzaW9uIDMxMTEyMSkKKysrIGJyYW5jaGVzL1BIUF81 XzQvZXh0L3Nlc3Npb24vdGVzdHMvc2Vzc2lvbl9lbmNvZGVfYmFzaWMucGhwdAkod29ya2luZyBj b3B5KQpAQCAtMSw1ICsxLDcgQEAKIC0tVEVTVC0tCiBUZXN0IHNlc3Npb25fZW5jb2RlKCkgZnVu Y3Rpb24gOiBiYXNpYyBmdW5jdGlvbmFsaXR5CistLUlOSS0tCitzZXJpYWxpemVfcHJlY2lzaW9u PTEwMAogLS1TS0lQSUYtLQogPD9waHAgaW5jbHVkZSgnc2tpcGlmLmluYycpOyA/PgogLS1GSUxF LS0K --00163630ef57ecd69504a378ec8d--