Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:52399
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.220.170 as permitted sender)
DomainKey-Status: bad
DomainKey-Signature: a=rsa-sha1; c=nofws;
        d=gmail.com; s=gamma;
        h=mime-version:date:message-id:subject:from:to:content-type;
        b=v01dF2vbtydTIr0ihZlqTrbcbytPuH4F3E4xaiRRmVFQGzv8vASvbgZbA6f8P8inrb
         YGIXxXvAkjjaBGy+tN5Z4fP8qIQgMo9pSfv5Swbg6UXnuZecF9TOTQ15iTIuDkdBzIFL
         sUzCCkCqOVsqliKEXKO0vZsDmD02DMBEF/eKE=
MIME-Version: 1.0
Date: Mon, 16 May 2011 14:14:04 -0400
Message-ID: <BANLkTimkMTitkMkJ32B32cwYc_5qpLyRhA@mail.gmail.com>
To: internals@lists.php.net
Content-Type: multipart/alternative; boundary=bcaec5486262e4408904a3689ed4
Subject: Inconsistencies with constructors in SPL
From: andrewcurioso@gmail.com (Andrew Curioso)

--bcaec5486262e4408904a3689ed4
Content-Type: text/plain; charset=ISO-8859-1

So, I ran across bug #54631

A fatal error is thrown if you try to call parent::__construct() from a
subclass
of SplObjectStorage.

I was going to close it as "expected behavior" since that is pretty normal
if the parent class doesn't implement __construct().
Also, the docs don't list it as having a __construct() method.

But then look at SplDoublyLinkedList (and a bunch of others). They are
documented
as having a __construct() method, yet it triggers a fatal error when you try
to call
"parent::__construct()" from a subclass' constructor .

So it seems to me that there are two possible solutions:

- Update the docs to remove ::__construct() for classes that don't have one.
- Make sure __construct() is implemented in all SPL classes * and update the
docs.

* Even if it is empty.

What's everyone thinking?

I'd be more than happy to add the constructors to the code where needed, I
just
want to make sure that it is the right move first.


- Andrew

--bcaec5486262e4408904a3689ed4--