Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:52393
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.160.170 as permitted sender)
DomainKey-Status: bad
DomainKey-Signature: a=rsa-sha1; c=nofws;
        d=gmail.com; s=gamma;
        h=mime-version:in-reply-to:references:from:date:message-id:subject:to
         :cc:content-type;
        b=wq/Ax3NKLlx3KM3kH+kR0AM9VIy9MT+8yOXmlAUVnCiIpvGoe+NnruUX1dhEV6QhQ4
         /gCX+s6hlr8Ugm7V5NLGj6sfnJLOJi5Uy6DSLblmbMnCUAsUYx4oVtNB3xLpQn5ep/Ys
         Ea+i3ubXX7OSZIqEZqbQMnl3cTkXFr0VPpWzs=
MIME-Version: 1.0
In-Reply-To: <BANLkTimnwkJgWCrwrM8PgPHgg_4Kj64eAw@mail.gmail.com>
References: <4DC729EE.9090600@sugarcrm.com> <8757232E56758B42B2EE4F9D2CA019C901401CB0@US-EX2.zend.net>
 <1305138029.2232.9.camel@guybrush> <691BF1CD-66E1-4123-AA98-A205A5E67F78@roshambo.org>
 <4DCADA70.7080505@sugarcrm.com> <41C30BEF-CC30-4A32-A8FB-2B8A6132804C@roshambo.org>
 <4DCB05F9.2000406@lerdorf.com> <BANLkTimnwkJgWCrwrM8PgPHgg_4Kj64eAw@mail.gmail.com>
Date: Mon, 16 May 2011 18:51:50 +0500
Message-ID: <BANLkTikXww0BLV+D03Ht5moTZEfwWU_MDQ@mail.gmail.com>
To: Rasmus Lerdorf <rasmus@lerdorf.com>
Cc: Philip Olson <philip@roshambo.org>, PHP Internals <internals@lists.php.net>
Content-Type: multipart/mixed; boundary=0016362839ea4c898f04a364f6e5
Subject: Re: [PHP-DEV] 5.4 again
From: confik@gmail.com (Alexey Shein)

--0016362839ea4c898f04a364f6e5
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable

It seems Rasmus already patched some date tests here:
http://svn.php.net/viewvc?view=3Drevision&revision=3D311014

And my second patch (in previous letter) about bug 51819 is wrong,
will try to investigate it further.

More test fixes:
/trunk/ext/curl/tests/curl_setopt_basic001.phpt should probably be
deleted, since it checked curl behavior in safe_mode and there's no
safe_mode anymore in trunk.
/trunk/ext/date/tests/DateInterval_format_a.phpt needs timezone set
(see attached patch)
/trunk/ext/session/tests/session_encode_basic.phpt - needs precision
serialize to be set (see attached patch)

I need some help with another bug. I'm looking into curl bug
http://bugs.php.net/48203 (test /trunk/ext/curl/tests/bug48203.phpt).
The bug is when std_err file pointer given to curl is closed before
calling curl_exec then curl causes segfault. How I can check that file
is already closed? File pointer is stored in zval as I can see
(ch->handlers->std_err in /ext/curl/interface.c around line 1852) .

2011/5/13 Alexey Shein <confik@gmail.com>:
> Hi, list.
>
> I've fixed some datetime tests in the trunk in answer to "Rasmus call
> for devs" :)
> There are two patches here.
> First patch is quite trivial - it fixes some relative/absolute path
> misconfiguration in phpt tests.
> Second patch fixes some timezone errors in bug51819 - some timezones
> like GB were not parsed correctly. Tests are ok now but don't know if
> my solution is correct.
> Hope these patches would be useful.
>
> P.S. Please, note I'm very new to C and will be happy if someone can
> answer to some of my newbie questions and gently point my mistakes :)
>
> 2011/5/12 Rasmus Lerdorf <rasmus@lerdorf.com>:
>> On 05/11/2011 02:10 PM, Philip Olson wrote:
>>
>>> So, that's the concern there. But if the alpha is simply a trick to
>>> convince people to test out a specific PHP 5.4 snapshot, and feel 5.4 i=
s
>>> real, then do it. ;)
>>
>> There are still quite a few test failures in trunk. Some of them are als=
o in
>> the 5_3 branch. In some cases the tests are simply bad. In a few the tes=
t
>> case contains binary data that got mangled in the move to Subversion. It
>> would be nice if just 1 in 10 people reading the list here would grab bo=
th
>> trunk and 5_3 and run "make test" in each tree and then fix at least 1 t=
est
>> each. We would have no test failures by the end of the day other than a =
few
>> tricky ones. If an alpha release will encourage this, great. If we could=
 get
>> people to just do it on their own without the alpha, even better.
>>
>> And yes, I know the tests take forever to run. Get yourself a fast machi=
ne
>> with an SSD, and remember you can run partial tests using:
>>
>> =C2=A0make test TESTS=3Dext/hash
>>
>> for example to just run the tests for the hash extension.
>>
>> Also, when a test fails, cd into the ext/hash/tests directory and you wi=
ll
>> see .out, .exp, .diff and .php files for the failed test. That is, the
>> output, the expected output, the diff between them and the php script it=
self
>> extracted from the .phpt file containing the failed test case.
>>
>> And if you can't figure out how to fix a test, post the details here. I'=
d
>> love to point some of the obvious talents and energy of this list toward=
s
>> the code. If you don't have an svn account for committing your fixed tes=
t,
>> go to http://www.php.net/svn-php.php and fill in the little form at the
>> bottom there and put in the test that you fixed and a 1-liner about how =
you
>> fixed it and I will set you up with an account right away. Info on how t=
o
>> check out the code from svn is here:
>> https://wiki.php.net/vcs/svnfaq
>>
>> -Rasmus
>>
>> --
>> PHP Internals - PHP Runtime Development Mailing List
>> To unsubscribe, visit: http://www.php.net/unsub.php
>>
>>
>
>
>
> --
> Regards,
> Shein Alexey
>



--=20
Regards,
Shein Alexey

--0016362839ea4c898f04a364f6e5
Content-Type: text/plain; charset=US-ASCII; name="date_interval_needs_timezone.patch.txt"
Content-Disposition: attachment; 
	filename="date_interval_needs_timezone.patch.txt"
Content-Transfer-Encoding: base64
X-Attachment-Id: f_gnrgsg3e2

SW5kZXg6IGV4dC9kYXRlL3Rlc3RzL0RhdGVJbnRlcnZhbF9mb3JtYXRfYS5waHB0Cj09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT0KLS0tIGV4dC9kYXRlL3Rlc3RzL0RhdGVJbnRlcnZhbF9mb3JtYXRfYS5waHB0CShyZXZpc2lv
biAzMTEwNjkpCisrKyBleHQvZGF0ZS90ZXN0cy9EYXRlSW50ZXJ2YWxfZm9ybWF0X2EucGhwdAko
d29ya2luZyBjb3B5KQpAQCAtOSw2ICs5LDcgQEAKIFdpbmRvd3MgVkM2IGxpYnMnIGZsb29yKCkv
Y2VpbCgpIGNob2tlIG9uIGZsb2F0cwogLS1GSUxFLS0KIDw/cGhwCitkYXRlX2RlZmF1bHRfdGlt
ZXpvbmVfc2V0KCdVVEMnKTsKIAogJGRhdGUxID0gbmV3IERhdGVUaW1lKCcyMDAwLTAxLTAxIDAw
OjAwOjAwJyk7CiAkZGF0ZTIgPSBuZXcgRGF0ZVRpbWUoJzIwMDEtMDMtMDQgMDQ6MDU6MDYnKTsK
--0016362839ea4c898f04a364f6e5
Content-Type: text/plain; charset=US-ASCII; 
	name="session_basic_needs_precision_set.patch.txt"
Content-Disposition: attachment; 
	filename="session_basic_needs_precision_set.patch.txt"
Content-Transfer-Encoding: base64
X-Attachment-Id: f_gnrguuxm3

SW5kZXg6IGV4dC9zZXNzaW9uL3Rlc3RzL3Nlc3Npb25fZW5jb2RlX2Jhc2ljLnBocHQKPT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PQotLS0gZXh0L3Nlc3Npb24vdGVzdHMvc2Vzc2lvbl9lbmNvZGVfYmFzaWMucGhwdAkocmV2
aXNpb24gMzExMDY5KQorKysgZXh0L3Nlc3Npb24vdGVzdHMvc2Vzc2lvbl9lbmNvZGVfYmFzaWMu
cGhwdAkod29ya2luZyBjb3B5KQpAQCAtMSw1ICsxLDcgQEAKIC0tVEVTVC0tCiBUZXN0IHNlc3Np
b25fZW5jb2RlKCkgZnVuY3Rpb24gOiBiYXNpYyBmdW5jdGlvbmFsaXR5CistLUlOSS0tCitzZXJp
YWxpemVfcHJlY2lzaW9uPTEwMAogLS1TS0lQSUYtLQogPD9waHAgaW5jbHVkZSgnc2tpcGlmLmlu
YycpOyA/PgogLS1GSUxFLS0K
--0016362839ea4c898f04a364f6e5--