Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:52368 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 27961 invoked from network); 13 May 2011 22:25:59 -0000 Received: from unknown (HELO lists.php.net) (127.0.0.1) by localhost with SMTP; 13 May 2011 22:25:59 -0000 Authentication-Results: pb1.pair.com header.from=andrewcurioso@gmail.com; sender-id=unknown Authentication-Results: pb1.pair.com smtp.mail=noreply@php.net; spf=pass; sender-id=pass Received-SPF: pass (pb1.pair.com: domain php.net designates 140.211.166.39 as permitted sender) X-PHP-List-Original-Sender: noreply@php.net X-Host-Fingerprint: 140.211.166.39 osu1.php.net Linux 2.4/2.6 Received: from [140.211.166.39] ([140.211.166.39:37192] helo=osu1.php.net) by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP id A1/90-18532-6FFADCD4 for ; Fri, 13 May 2011 18:25:59 -0400 Authentication-Results: osu1.php.net header.from=andrewcurioso@gmail.com; sender-id=neutral Authentication-Results: osu1.php.net smtp.mail=noreply@php.net; spf=neutral; sender-id=neutral Received: from [127.0.0.1] ([127.0.0.1:37184] helo=osu1.php.net) by osu1.php.net (envelope-from ) (ecelerity 2.2.3.46 r(36781)) with ESMTP id 77/A6-03570-F23BDCD4; Fri, 13 May 2011 15:39:43 -0700 Received: (from apache@localhost) by osu1.php.net (8.12.11/8.12.11/Submit) id p4DMdfar013754; Fri, 13 May 2011 15:39:41 -0700 Date: Fri, 13 May 2011 15:39:41 -0700 To: internals@lists.php.net Message-ID: Subject: SVN Account Request: acurioso From: andrewcurioso@gmail.com ("Andrew Curioso") Rasmus encouraged me to... in his php.internals message on May 11 "Re: 5.4 again". Fixed the issue documented in test ext/simplexml/tests/034.phpt (an almost 2 year old "expected fail") The fix was non-trivial. It uses the iterator where appropriate to enumerate the property hash instead of traversing via ->next. This slightly changes the behavior of var_dump() on SimpleXMLElement (enough to break 1 additional test, bug51615, which I then updated so it passes) so I'm more than happy to discuss it on the php.internals list before committing my code.