Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:52262
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.160.170 as permitted sender)
DomainKey-Status: bad
DomainKey-Signature: a=rsa-sha1; c=nofws;
        d=gmail.com; s=gamma;
        h=mime-version:in-reply-to:references:from:date:message-id:subject:to
         :cc:content-type:content-transfer-encoding;
        b=cb3mZUBjl0npOtgyY2MuPDE1SvTQ5r8oSSzx1onG6Zn31mu4Qd4j7wsaBBhJr84+/d
         bk77fCIv/wJccKNFmwD02nggTwm2pYbnuL2tHFbb6l5UcKgPHSdrRf5DDT8/A9YyBhwX
         7V1qG2OMzzJXbawoEVRczjSSlfFQvM9UQO6LQ=
MIME-Version: 1.0
In-Reply-To: <4DC9B62C.2040009@toolpark.com>
References: <BANLkTinO0h7020fs+PLjM0fUmMjQXoTsyw@mail.gmail.com>
 <BANLkTim8p7A5+svvjZw6rc_KE+tBMnOsjw@mail.gmail.com> <4DC826B1.4090806@lerdorf.com>
 <BANLkTikpLY+AntSrNi91rzGNZi4FkPrSwA@mail.gmail.com> <4DC82A36.8090604@lerdorf.com>
 <BANLkTi=aLVw8KqOV_jb9dBm=XqX6TqTVwA@mail.gmail.com> <4DC83401.2090202@sugarcrm.com>
 <BANLkTiniayhZ+8CRQjPFBDLOBu=E7UUv=A@mail.gmail.com> <BANLkTimvE1nE+UOv+8hUaPiyfozn3PgU3Q@mail.gmail.com>
 <BANLkTinfEFsiSWOi3RgjZ4-6QeNjRVMwTQ@mail.gmail.com> <4DC8D122.3050507@lsces.co.uk>
 <BANLkTim1euVOKXxLc3FdhJAywqnPHDkbwg@mail.gmail.com> <BANLkTi=AxkZf_jMUJ0MaRREVX9t33Ex0Zw@mail.gmail.com>
 <4DC8F125.2010503@toolpark.com> <BANLkTim5MbJV29xjx3b3+9VofVuCKVhh3g@mail.gmail.com>
 <4DC947E3.8070606@toolpark.com> <BANLkTinaejEAznJoyuk09jrB2TroDk+A+A@mail.gmail.com>
 <4DC9B62C.2040009@toolpark.com>
Date: Tue, 10 May 2011 19:28:06 -0300
Message-ID: <BANLkTikaM+m+Pd125q16xdncm067KHizJg@mail.gmail.com>
To: Lars Schultz <lars.schultz@toolpark.com>
Cc: internals@lists.php.net
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
Subject: Re: [PHP-DEV] annotations again
From: guilhermeblanco@gmail.com ("guilhermeblanco@gmail.com")

Not trying to be harsh, but I'm not bloating my PHP example.
That's the actual way Doctrine supports Metadata information. I can explain=
 why.

Conceptually, an architectural design of an entity should not know
anything about its persistence information.
By that means, we cannot for example implement an interface (which
seems you have forgotten to add) or an abstract class for
"getAnnotations()" method.
If you enforce people to implement an abstract class or even an
interface, you bring 2 problems:
- Entities with knowledge about its persistence information
- Resources being wasted
- You rely on an instance to grab information. Or you use a slow
approach of having a static method

The second argument is valid because in a request you're able to deal
with an average number of methods. Each method is a pointer of 4
bytes.
By having an "irrelevant" method on entity, you consume (on a page
with 500 entities), 2000 bytes of unnecessary resources.

The third argument is exactly what we had on Doctrine 1. We relied on
a ghost entity for metadata retrieval. This brings a whole new level
of issues to deal with.
Making it static, slow down a lot the overall ClassMetadata retrieval
information.

Also, there are much more things than you can actually think of related to =
this.
The code is not bloated. Since you don't have a "pre-processor"  for
class metadatas, you have to build all definitions manually. This is
why you have to set inheritance type, for example.
$metadata->setInheritanceType(ClassMetadataInfo::INHERITANCE_TYPE_NONE);

FYI, Doctrine took an year of planning an another year of careful
implementation of each feature.
This means to you that every single feature was carefully planned,
optimized and implemented with performance, good OO design and
extensibility. =3D)


Cheers,

On Tue, May 10, 2011 at 7:03 PM, Lars Schultz <lars.schultz@toolpark.com> w=
rote:
> Am 10.05.2011 17:07, schrieb guilhermeblanco@gmail.com:
>>
>> Is that still simple?
>
> You bloated the php example unnecessarily. This contains the same
> information as your Annotations example, which to me, is very similar.
>
> http://pastie.org/1886774
>
>
> --
> PHP Internals - PHP Runtime Development Mailing List
> To unsubscribe, visit: http://www.php.net/unsub.php
>
>



--=20
Guilherme Blanco
Mobile: +55 (16) 9215-8480
MSN: guilhermeblanco@hotmail.com
S=C3=A3o Paulo - SP/Brazil