Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:52191
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.213.42 as permitted sender)
DomainKey-Status: bad
DomainKey-Signature: a=rsa-sha1; c=nofws;
        d=gmail.com; s=gamma;
        h=mime-version:in-reply-to:references:from:date:message-id:subject:to
         :cc:content-type:content-transfer-encoding;
        b=B4cfHXyWTgTj6O8G4PUeLy5e6v70mdnPj1LRSL+g6FojeOh7huEHHScIBJOabBHOTp
         ImDesGrF582A/X4P+ck+enlLm+SUmZ9SDUIP9xdskHgu1LjOZiND5pzCuymPTfoqNrJI
         +NebbeRr5J3VeY8xncAKSEh+AGaEuxX9EClio=
MIME-Version: 1.0
In-Reply-To: <4DC8885C.9090608@sugarcrm.com>
References: <BANLkTinO0h7020fs+PLjM0fUmMjQXoTsyw@mail.gmail.com>
 <BANLkTim8p7A5+svvjZw6rc_KE+tBMnOsjw@mail.gmail.com> <4DC826B1.4090806@lerdorf.com>
 <BANLkTikpLY+AntSrNi91rzGNZi4FkPrSwA@mail.gmail.com> <4DC82A36.8090604@lerdorf.com>
 <BANLkTi=aLVw8KqOV_jb9dBm=XqX6TqTVwA@mail.gmail.com> <4DC85FBE.2060005@lsces.co.uk>
 <BANLkTikH4H140xh8YLL_J+3dUS6UQAozhw@mail.gmail.com> <4DC8885C.9090608@sugarcrm.com>
Date: Mon, 9 May 2011 21:55:42 -0300
Message-ID: <BANLkTim1A3h9aVLz=_CfarqbLswF3mek9g@mail.gmail.com>
To: Stas Malyshev <smalyshev@sugarcrm.com>
Cc: Lester Caine <lester@lsces.co.uk>, PHP internals <internals@lists.php.net>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
Subject: Re: [PHP-DEV] Please let's not bitch about lazy users not learning C
 to implement THEIR missing feature. (Was Re: [PHP-DEV] 5.4 again)
From: guilhermeblanco@gmail.com ("guilhermeblanco@gmail.com")

Hi Stas,

On Mon, May 9, 2011 at 9:35 PM, Stas Malyshev <smalyshev@sugarcrm.com> wrot=
e:
> Hi!
>
>> I updated the RFC. I may have missed one thing or two, but overall
>> idea and how code behave is there.
>> This question is answered on wiki RFC. =3D)
>>
>> Here is the direct link: https://wiki.php.net/rfc/annotations
>
> Some questions I didn't find the answers in the RFC:
> 1. When the annotation objects are instantiated?

Objects are only instantiated when requested (getAnnotations() or
getAnnotation())

> 2. What is permissible in the arguments of annotation - e.g. can I put an=
y
> expression there?

You are allowed to use any scalar value + array + any object that
implements ReflectionAnnotation interface.

> 3. What <Foo(<Bar>)> actually means and how it is supposed to be parsed?

It would instantiate a class Bar and would pass it as an instance of
Foo that is also being created when doing getAnnotations() or
getAnnotation('Foo')

> 4. What happens if ctor for annotation has error/exception?

There're error support just like PHP has. Here is a sample:

Fatal error: Uncaught exception 'Exception' with message 'Fooooo' in
/src/php-src/trunk/ok.php:6
Stack trace:
#0 [internal function]: simpleannotation->__construct()
#1 /src/php-src/trunk/ok.php(15):
ReflectionClass->getAnnotation('simpleannotatio...')
#2 {main}
  thrown in /src/php-src/trunk/ok.php on line 6

Code:

class SimpleAnnotation implements ReflectionAnnotation {
    public function __construct()
    {
        throw new Exception('Fooooo');
    }
}

<SimpleAnnotation>
class Foo {
}

$r =3D new ReflectionClass('Foo');
var_dump($r->getAnnotation('SimpleAnnotation'));

> 5. Are there any limitations on classes that can be used as annotations?

As I said, only classes that implement ReflectionAnnotation are
allowed to be used. It gives errors if you attempt to do something
invalid.
Here is the error you get if you attempt to use a non-declared annotation:

class Foo implements ReflectionAnnotation {
    public function __construct($bar)
    {}
}

class Bar {}

<Foo(<Bar>)>
class FooBar {
}

$r =3D new ReflectionClass('FooBar');
var_dump($r->getAnnotations());

Fatal error: ReflectionClass::getAnnotations(): 'Bar' must implement
'ReflectionAnnotation' to act as an annotation in - on line 15


> 6. Do we need any special support for bytecode caches?

Yes. Every structure which can be annotated now will have a new member
in their C structure which is annotations, this structure is populated
at compile time and store all the metadata information. So if you have
an opcode cache the compilation will not occur, so the annotations
will be NULL. That's why the opcode cache will have to store the
annotations, so that it can be retrieved every time.

>
> --
> Stanislav Malyshev, Software Architect
> SugarCRM: http://www.sugarcrm.com/
> (408)454-6900 ext. 227
>



--=20
Guilherme Blanco
Mobile: +55 (16) 9215-8480
MSN: guilhermeblanco@hotmail.com
S=C3=A3o Paulo - SP/Brazil