Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:52177 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 99764 invoked from network); 9 May 2011 18:38:34 -0000 Received: from unknown (HELO lists.php.net) (127.0.0.1) by localhost with SMTP; 9 May 2011 18:38:34 -0000 Authentication-Results: pb1.pair.com smtp.mail=guilhermeblanco@gmail.com; spf=pass; sender-id=pass Authentication-Results: pb1.pair.com header.from=guilhermeblanco@gmail.com; sender-id=pass; domainkeys=bad Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.160.170 as permitted sender) DomainKey-Status: bad X-DomainKeys: Ecelerity dk_validate implementing draft-delany-domainkeys-base-01 X-PHP-List-Original-Sender: guilhermeblanco@gmail.com X-Host-Fingerprint: 209.85.160.170 mail-gy0-f170.google.com Received: from [209.85.160.170] ([209.85.160.170:40597] helo=mail-gy0-f170.google.com) by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP id DD/B0-20726-9A438CD4 for ; Mon, 09 May 2011 14:38:34 -0400 Received: by gyb11 with SMTP id 11so2317669gyb.29 for ; Mon, 09 May 2011 11:38:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc:content-type:content-transfer-encoding; bh=pXBP2deIRPmKuqzSS6JKeDVZ/JxYhEYsdIhiUQNeguY=; b=WV7W6XPbO3/QMP5tJz4Z1SHYAosUX+rMoIH1IIPVpdpo1uEX8baKeQvbRPvfT+7XHd vfHXK6mAam5FW9CgMfJm/BsSFmJChAlfUwV+Hy5C5P+KC3UtKcAesBa36M+vw+mP0IXK Zv2TNUQZaEU9Z0f6ezUSZsy5Xz3yIIQqY/I84= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc:content-type:content-transfer-encoding; b=puAH/XYgsiVEbtpeVhYBWBqUAn8QHfIf1R2RkU49baney0SXNDC/nRwXyiOpn+siS6 UHQsqvZeGnWg67wx6uny+Foa8JS+0GFJ4nZ2XpJJg/jz8AJONYSqcHlxD5f+NtozqADN kq3xKBerbK/Aj4DqQsfTLz/ff+fwKZ09rN5I8= Received: by 10.236.183.194 with SMTP id q42mr8410078yhm.43.1304966310268; Mon, 09 May 2011 11:38:30 -0700 (PDT) MIME-Version: 1.0 Received: by 10.147.171.4 with HTTP; Mon, 9 May 2011 11:38:10 -0700 (PDT) In-Reply-To: References: <20110313213356.GC4446@crousti> <20110313215222.GE4446@crousti> Date: Mon, 9 May 2011 15:38:10 -0300 Message-ID: To: Ferenc Kovacs Cc: Pierre Joye , Marcelo Gornstein , Etienne Kneuss , internals@lists.php.net Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Subject: Re: [PHP-DEV] native php annotations From: guilhermeblanco@gmail.com ("guilhermeblanco@gmail.com") Hi Ferenc, I'll update the RFC to match the current implementation. Pierrick is working to extract a diff more simplified so you can quickly look at it. Thanks. On Mon, May 9, 2011 at 3:32 PM, Ferenc Kovacs wrote: > > > On Mon, Mar 14, 2011 at 7:02 PM, guilhermeblanco@gmail.com > wrote: >> >> Hi all, >> >> I promise myself to not revamp this discussion again, but it wasn't me >> this time! >> >> @Etienne: That RFC is outdated. >> Since the last feedback form internals list, a lot of changes have >> been made to that RFC. Maybe I should update it ASAP so you can >> clearly understand what have changed to be compatible with current PHP >> syntax. >> >> If you are interested, Pierrick moved all the recent developments to a >> github repository, which can be reached here: >> https://github.com/adoy/PHP-Annotations >> >> Take a look at some tests: >> >> https://github.com/adoy/PHP-Annotations/blob/master/tests/annotations/pa= rser_021.phpt >> >> https://github.com/adoy/PHP-Annotations/blob/master/tests/annotations/Re= flectionParameter_getAnnotations_003.phpt >> >> https://github.com/adoy/PHP-Annotations/blob/master/tests/annotations/Re= flectionClass_getAnnotations_004.phpt >> >> Also, there's even an alternative patch that support positioned >> parameters instead of named ones. >> We just have to reach an agreement with what PHP core want. >> >> @Marcelo: While your proposal looks very good, it lacks of the support >> to nested Annotation. >> Consider how userland/framework would use your idea. For example, >> Symfony2 supports validation of data inside classes inspired on >> JSR-303 (Bean Validation). >> >> Symfony2 takes an advantage of a library Doctrine group (which I'm a >> core member) created by parsing docblocks. When we created this >> parser, I created this RFC with the good intention that PHP could >> benefit of this known feature to enhance current userland >> developments. >> The first thing you need is your application still running ok with and >> without comments. This already breaks all suggestions of creating a >> PECL extension of docblock parser. >> >> >> >> I'd like to see what people think about it and make something "IN" on >> next PHP major version. >> >> > > now that the wiki is back and this was brought up in the 5.4 release > planning, I think it would be a good idea to: > - update the RFC to be in sync with the implementation > - review the rfc and the patch itself > - make the=C2=A0necessary=C2=A0modifications if=C2=A0necessary > - decide whether we want this in 5.4 or not. > Tyrael --=20 Guilherme Blanco Mobile: +55 (16) 9215-8480 MSN: guilhermeblanco@hotmail.com S=C3=A3o Paulo - SP/Brazil