Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:52175
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.215.42 as permitted sender)
DomainKey-Status: bad
DomainKey-Signature: a=rsa-sha1; c=nofws;
        d=gmail.com; s=gamma;
        h=mime-version:sender:in-reply-to:references:date
         :x-google-sender-auth:message-id:subject:from:to:cc:content-type;
        b=P9RtqBADvvyhvrHQCPeV6RlDKQP3bNUsCew611G9eGDtoJe04hcn+5DSPpxSOHdCSc
         aDpRZRq/dcUBGhymUo8GnSJcCTNiuMyPcPe5VroMpqwt4NX2GdrfYwwLGN7SV/4X107U
         t1A8fXtETdNDHLTOJF5AZeHc45O3XPclQE0wE=
MIME-Version: 1.0
Sender: tyra3l@gmail.com
In-Reply-To: <AANLkTikXHiq6DWegx8=5eBnZdS0DAzfZyD0quYitTfaR@mail.gmail.com>
References: <AANLkTimkwFTD+Da2FhORfqJvT2WAXBni=SY5QLFZ+8Y8@mail.gmail.com>
	<20110313213356.GC4446@crousti>
	<AANLkTikbR7Wz9r4c0YCcwLp8+zMunhOBP9O5_KV54HWC@mail.gmail.com>
	<20110313215222.GE4446@crousti>
	<AANLkTimhyMo535YU_AC7Cm-cj5ACA4Q_8=cEfTTRLk5_@mail.gmail.com>
	<AANLkTin9P6us47ZH03EFK5RsoMoRHASbyq2OHo7d2Vtu@mail.gmail.com>
	<AANLkTikXHiq6DWegx8=5eBnZdS0DAzfZyD0quYitTfaR@mail.gmail.com>
Date: Mon, 9 May 2011 20:32:09 +0200
Message-ID: <BANLkTi=hYCBiZqrKJ2E8as-p-ka3hNZQfw@mail.gmail.com>
To: "guilhermeblanco@gmail.com" <guilhermeblanco@gmail.com>
Cc: Pierre Joye <pierre.php@gmail.com>, Marcelo Gornstein <marcelog@gmail.com>, 
	Etienne Kneuss <colder@php.net>, internals@lists.php.net
Content-Type: multipart/alternative; boundary=90e6ba615412b2924604a2dc0e0d
Subject: Re: [PHP-DEV] native php annotations
From: info@tyrael.hu (Ferenc Kovacs)

--90e6ba615412b2924604a2dc0e0d
Content-Type: text/plain; charset=UTF-8

On Mon, Mar 14, 2011 at 7:02 PM, guilhermeblanco@gmail.com <
guilhermeblanco@gmail.com> wrote:

> Hi all,
>
> I promise myself to not revamp this discussion again, but it wasn't me
> this time!
>
> @Etienne: That RFC is outdated.
> Since the last feedback form internals list, a lot of changes have
> been made to that RFC. Maybe I should update it ASAP so you can
> clearly understand what have changed to be compatible with current PHP
> syntax.
>
> If you are interested, Pierrick moved all the recent developments to a
> github repository, which can be reached here:
> https://github.com/adoy/PHP-Annotations
>
> Take a look at some tests:
>
> https://github.com/adoy/PHP-Annotations/blob/master/tests/annotations/parser_021.phpt
>
> https://github.com/adoy/PHP-Annotations/blob/master/tests/annotations/ReflectionParameter_getAnnotations_003.phpt
>
> https://github.com/adoy/PHP-Annotations/blob/master/tests/annotations/ReflectionClass_getAnnotations_004.phpt
>
> Also, there's even an alternative patch that support positioned
> parameters instead of named ones.
> We just have to reach an agreement with what PHP core want.
>
> @Marcelo: While your proposal looks very good, it lacks of the support
> to nested Annotation.
> Consider how userland/framework would use your idea. For example,
> Symfony2 supports validation of data inside classes inspired on
> JSR-303 (Bean Validation).
>
> Symfony2 takes an advantage of a library Doctrine group (which I'm a
> core member) created by parsing docblocks. When we created this
> parser, I created this RFC with the good intention that PHP could
> benefit of this known feature to enhance current userland
> developments.
> The first thing you need is your application still running ok with and
> without comments. This already breaks all suggestions of creating a
> PECL extension of docblock parser.
>
>
>
> I'd like to see what people think about it and make something "IN" on
> next PHP major version.
>
>
>
now that the wiki is back and this was brought up in the 5.4 release
planning, I think it would be a good idea to:
- update the RFC to be in sync with the implementation
- review the rfc and the patch itself
- make the necessary modifications if necessary
- decide whether we want this in 5.4 or not.

Tyrael

--90e6ba615412b2924604a2dc0e0d--