Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:52073
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.220.170 as permitted sender)
DomainKey-Status: bad
DomainKey-Signature: a=rsa-sha1; c=nofws;
        d=gmail.com; s=gamma;
        h=mime-version:in-reply-to:references:date:message-id:subject:from:to
         :cc:content-type;
        b=GWfSaB4CXNCvG/ITuj+lcPbrH6D5Rw8ZezZeA7o6BKE7GHrG+BiWp+vtBmxLqDf1T/
         Xu6J11E/Ju7QuscUDTMjNi3gqAJars+jZo8Cwfi2FkeGf7FyfT74rIs6w/17V2AADL0p
         v9DWkAwVvZkwi/pZxL3ZbqoL37N4AMBPhV8AQ=
MIME-Version: 1.0
In-Reply-To: <1304016828.1561.103.camel@guybrush>
References: <AANLkTimDdM4Udx53qW8jU4NuP3kU8+vmU6y4ZgXRVn+X@mail.gmail.com>
	<BANLkTinMW_iqqOPJCuLnCB+-VEKxapPdGg@mail.gmail.com>
	<4DB923E6.3020307@sugarcrm.com>
	<BANLkTi=4FzRJuYpK3C_ZD=JYZq2xq6hzJw@mail.gmail.com>
	<4DB9A7BE.6010307@sugarcrm.com>
	<BANLkTinB6rbzxWRJzyp1Nr+eLh8TO3tfFg@mail.gmail.com>
	<1304016828.1561.103.camel@guybrush>
Date: Thu, 28 Apr 2011 16:20:14 -0300
Message-ID: <BANLkTi=DtBC5sDEWASXmfWA3Ovqf4rvAbg@mail.gmail.com>
To: =?ISO-8859-1?Q?Johannes_Schl=FCter?= <johannes@schlueters.de>
Cc: Ferenc Kovacs <info@tyrael.hu>, Stas Malyshev <smalyshev@sugarcrm.com>, 
	Felipe Pena <felipensp@gmail.com>, internals <internals@lists.php.net>
Content-Type: multipart/alternative; boundary=20cf3071c7e8631a8804a1ff726c
Subject: Re: [PHP-DEV] [RFC] Return type-hint
From: martinscotta@gmail.com (Martin Scotta)

--20cf3071c7e8631a8804a1ff726c
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: quoted-printable

 Martin Scotta


2011/4/28 Johannes Schl=FCter <johannes@schlueters.de>

> On Thu, 2011-04-28 at 20:04 +0200, Ferenc Kovacs wrote:
> > > Why I need being "saved" from documenting my code properly? Anyway, t=
he
> > > function code defines the behavior, declaration of return type just
> ensures
> > > function would fail in runtime if your code tries to return unexpecte=
d
> data
> > > - but how is it helpful? The client of this function doesn't even kno=
w
> that
> > > before actually calling it!
> >
> >
> > why did we added ppp if people can define in the documentation(or in th=
e
> > method name :/) that which method is public and which isn't
>
> with ppp i prevent the client code from doing something the
> function/class author didn't expect. With this return hint the function
> auther can force a runtime error when doing something wrong himself.
> (which he has to check one way or the other using tests etc.)
>
>
Return types are meant to ensure that you get what you asked for. This is
really useful when you need to delegate to some component, specially if it'=
s
not of your own, although there are ways to avoid that patterns.

IMHO I would not trust on any return value, as PHP did not ensure anything
about them.
Even more, I do not write code that depend on return values, I prefer to
use input/output parameters,

This is the safer way I've found to achieve the same behavior

function no_return(ReturnStatus $returnStatus) {
   doSomething();

   if ( itWasOk() )
   {
       $returnStatus->setReturnValue( new Foo ); // return type hint
       $returnStatus->success(); // return status
   }
   elseif ( isWasCritical() )
   {
       $returnStatus->setException( new RuntimeException );
       $returnStatus->exception(); // return status
   }
   else
   {
       $returnStatus->fail(); // return status
   }
}

Of course I don't write all functions like this.
This is pattern I use when I need to ensure that the type returned is valid=
.

johannes
>
>
>
> --
> PHP Internals - PHP Runtime Development Mailing List
> To unsubscribe, visit: http://www.php.net/unsub.php
>
>

--20cf3071c7e8631a8804a1ff726c--