Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:51955 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 13363 invoked from network); 20 Apr 2011 15:12:13 -0000 Received: from unknown (HELO lists.php.net) (127.0.0.1) by localhost with SMTP; 20 Apr 2011 15:12:13 -0000 Authentication-Results: pb1.pair.com header.from=addw@phcomp.co.uk; sender-id=permerror Authentication-Results: pb1.pair.com smtp.mail=addw@phcomp.co.uk; spf=pass; sender-id=pass Received-SPF: pass (pb1.pair.com: domain phcomp.co.uk designates 80.68.91.63 as permitted sender) X-PHP-List-Original-Sender: addw@phcomp.co.uk X-Host-Fingerprint: 80.68.91.63 bytemark.phcomp.co.uk Received: from [80.68.91.63] ([80.68.91.63:49733] helo=bytemark.phcomp.co.uk) by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP id A5/34-24878-BC7FEAD4 for ; Wed, 20 Apr 2011 11:12:12 -0400 Received: from freshmint.phcomp.co.uk ([78.32.209.33] helo=mint.phcomp.co.uk) by bytemark.phcomp.co.uk with esmtps (TLSv1:AES256-SHA:256) (Exim 4.71) (envelope-from ) id 1QCZ4X-0000bd-Td; Wed, 20 Apr 2011 16:12:05 +0100 Received: from addw by mint.phcomp.co.uk with local (Exim 4.63) (envelope-from ) id 1QCZ4X-000387-EA; Wed, 20 Apr 2011 16:12:05 +0100 Date: Wed, 20 Apr 2011 16:12:05 +0100 To: Mark Cc: internals@lists.php.net Message-ID: <20110420151205.GI32571@phcomp.co.uk> Mail-Followup-To: Mark , internals@lists.php.net References: Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.4.2.2i Organization: Parliament Hill Computers Ltd Subject: Re: [PHP-DEV] Function proposal: varset From: addw@phcomp.co.uk (Alain Williams) On Wed, Apr 20, 2011 at 04:55:00PM +0200, Mark wrote: > Hi, > > This proposal is for the often called line like this: > $var = isset($_GET['var']) ? $_GET['var'] : ''; > > Only a shorter and imho a cleaner solution to get the same: > $var = varset($_GET['var']); It should be called var_set() - better on name space pollution. > However there is a slight issue with this approach. If notices are turned on > this code will generate a notice while i think it should not do that. But > perhaps this approach is "to short". > A slightly different implementation (and longer) prevents the notice: If is is a language element (like isset()) then you can avoid this problem. I do find a lot of code, in simple scripts, that does just that. It might be nice to extend it such that if the 1st argument is a list then the first in the list which is set is returned, eg: $var = var_set(($_GET['var'], $_POST['var']), 'default'); -- Alain Williams Linux/GNU Consultant - Mail systems, Web sites, Networking, Programmer, IT Lecturer. +44 (0) 787 668 0256 http://www.phcomp.co.uk/ Parliament Hill Computers Ltd. Registration Information: http://www.phcomp.co.uk/contact.php #include