Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:51869
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.214.170 as permitted sender)
DomainKey-Status: bad
DomainKey-Signature: a=rsa-sha1; c=nofws;
        d=gmail.com; s=gamma;
        h=subject:mime-version:content-type:from:in-reply-to:date:cc
         :content-transfer-encoding:message-id:references:to:x-mailer;
        b=EJMJ6I0a9HnKjFF+Pr7wyRtqiKuTG+wdrKdCjYfYqMfZyisG+/7+SccjLbxJMiAeRD
         DEKtPwK8iSF/yVX1nQ3hvd7S2KIqI1tqvm3N82N4Xn5vK7dWSHrIpqhtayHZSSqPKjUE
         JyFpk/E+wSOOGymdsp8xuEYwBuZ6YZHSicCvI=
Mime-Version: 1.0 (Apple Message framework v1084)
Content-Type: text/plain; charset=us-ascii
In-Reply-To: <1302548895.15421.18.camel@inspiron>
Date: Mon, 11 Apr 2011 14:14:40 -0500
Cc: Internals Mailing List <internals@lists.php.net>
Content-Transfer-Encoding: quoted-printable
Message-ID: <BE54873C-66E4-45B2-9B68-1CD61A314D8F@gmail.com>
References: <4DA26602.6080303@lorenso.com>	<20110411133657.GK7113@crousti> <BANLkTi=Gnb_8xvYgdwZdPmis4g2o5g0r-w@mail.gmail.com> <4DA3468E.8000509@sugarcrm.com> <1302548895.15421.18.camel@inspiron>
To: truth@proposaltech.com
Subject: Re: [PHP-DEV] Avoiding "Undefined index" notices
From: shadda@gmail.com (Matt Wilson)

Something I've been doing for a long time is similar, but in my opinion =
a much better practice.

function coalesce(&$val, $ifnull =3D false)
{
	return empty($val) ? $ifnull : $val;
}

Add whatever restrictive logic you wish here, if empty() isn't good =
enough for your purposes.=20

$_GET['mightnotexist'] =3D coalesce($_GET['mightnotexist'], 'default');

Personally, I think if you're writing your code where a variable's =
existence is ambiguous, you *should* be seeing notices.

On Apr 11, 2011, at 2:08 PM, Todd Ruth wrote:

> I'm not arguing whether the following code fragment is good
> or bad (it's certainly less than ideal), but given the recent=20
> threads, I thought I'd show how I feel I've been encourage by=20
> php to code:
>=20
> <?php
> $x =3D array();
> $y =3D 'something';
> $temp =3D& $x[$y];
> $temp++;
> unset($temp);
> ?>
>=20
> I'm not sure where (if anywhere) that technique is documented
> or even if it should be documented, but if you want to avoid
> "Undefined index" notices, that's one of the more terse
> approaches.  The relative brevity is more obvious when the
> variable names are long and $temp is re-linked several times
> before unsetting.  It's probably less clear than alternatives
> unless you see it often.
>=20
> Here is an application to the defaults for configurations thread:
>=20
> <?php
> $config =3D array();
> $param =3D 'param1';
> $temp =3D& $config[$param];
> $temp =3D $temp ?: 'default';
> unset($temp);
> var_dump($config);
> ?>
>=20
> It isn't beautiful, but it avoids writing "$config[$param]"
> more than once and it avoids the notices.
>=20
> - Todd
>=20
>=20
> --=20
> PHP Internals - PHP Runtime Development Mailing List
> To unsubscribe, visit: http://www.php.net/unsub.php
>=20