Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:51847
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.214.42 as permitted sender)
DomainKey-Status: bad
DomainKey-Signature: a=rsa-sha1; c=nofws;
        d=gmail.com; s=gamma;
        h=mime-version:in-reply-to:references:date:message-id:subject:from:to
         :cc:content-type:content-transfer-encoding;
        b=mLq/jbLgStzDHRKolDYHpllwHVHcHMKTxbh/1DjTuf78G8ErprNFD/UZlZOEzZh+4S
         k+wDffyMlV2O12BWECQnN1KcqHzcMAq8b+jxRw/OWstlauwFEL6QEKrvaDQjepyKED7v
         kVZf9FFtsv2qz/HGpBiO6ux+shv/mFFTRztLo=
MIME-Version: 1.0
In-Reply-To: <4D9F4CBE.2090208@php.net>
References: <4D99E241.4050100@php.net>
	<4D9F4CBE.2090208@php.net>
Date: Fri, 8 Apr 2011 22:02:49 +0200
Message-ID: <BANLkTi=Vf7GE0+GxMYmAoZfVqSt0Md5qoA@mail.gmail.com>
To: Sebastian Bergmann <sebastian@php.net>
Cc: internals@lists.php.net
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
Subject: Re: [PHP-DEV] Optional $limit argument for debug_backtrace()
From: patrick.allaert@gmail.com (Patrick ALLAERT)

2011/4/8 Sebastian Bergmann <sebastian@php.net>:
> Am 04.04.2011 17:22, schrieb Sebastian Bergmann:
>> Any thoughts?
>
> =C2=A0Are there any objections to applying the latest version of the patc=
h [1]
> =C2=A0to trunk? I still think that debug_backtrace and debug_print_backtr=
ace
> =C2=A0are in need of refactoring but that should be kept separate, I thin=
k.

Not that this is a true blocker, but as said previously, and
considering the very few changes it introduces
(https://gist.github.com/910580), I'm not really in favor to introduce
it only in debug_bactrack() and not in debug_print_backtrace().
Both should be refactored, true, but I don't see the point to make them div=
erge.
I would even say that there is more benefit in terms of maintenance to
make them common now than introducing new feature to them.

Regards,
Patrick