Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:51822
Return-Path: <patrick.allaert@gmail.com>
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Delivered-To: mailing list internals@lists.php.net
Received: (qmail 99734 invoked from network); 5 Apr 2011 13:23:53 -0000
Received: from unknown (HELO lists.php.net) (127.0.0.1)
  by localhost with SMTP; 5 Apr 2011 13:23:53 -0000
Authentication-Results: pb1.pair.com header.from=patrick.allaert@gmail.com; sender-id=pass; domainkeys=bad
Authentication-Results: pb1.pair.com smtp.mail=patrick.allaert@gmail.com; spf=pass; sender-id=pass
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.215.170 as permitted sender)
DomainKey-Status: bad
X-DomainKeys: Ecelerity dk_validate implementing draft-delany-domainkeys-base-01
X-PHP-List-Original-Sender: patrick.allaert@gmail.com
X-Host-Fingerprint: 209.85.215.170 mail-ey0-f170.google.com  
Received: from [209.85.215.170] ([209.85.215.170:52431] helo=mail-ey0-f170.google.com)
	by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP
	id 50/A9-37955-7E71B9D4 for <internals@lists.php.net>; Tue, 05 Apr 2011 09:23:52 -0400
Received: by eyf5 with SMTP id 5so101270eyf.29
        for <internals@lists.php.net>; Tue, 05 Apr 2011 06:23:49 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=gamma;
        h=domainkey-signature:mime-version:sender:in-reply-to:references:date
         :x-google-sender-auth:message-id:subject:from:to:cc:content-type
         :content-transfer-encoding;
        bh=Xwtbu7kurD5z9+gus1kgoS7cSPiLBt0l+WM7Nohutcw=;
        b=pTKsMjPhm42j1hu3xG2zNqwoCKi5QAICok1j5hZK7GPz/KzHFcfykGFw7LtTUF9v5j
         YvGEQ+4Nl/3vVsMHDI13xQ74Eb/Orz1wGU5703EmE3RBFmgMLqjr5f61qaY1Uzu9eHwS
         j7DI/AjYBDfl4bpwMvhRD9ZaJQBBIMjI890cw=
DomainKey-Signature: a=rsa-sha1; c=nofws;
        d=gmail.com; s=gamma;
        h=mime-version:sender:in-reply-to:references:date
         :x-google-sender-auth:message-id:subject:from:to:cc:content-type
         :content-transfer-encoding;
        b=YSC4n8BXsOBZKSlK1sufZQQW0y8CKZNTUzUYZUuXFVgTkXT9JZod8ndybZIAmhepGA
         pQt+3HIp1vWWYIKXhbXM0vgVJ1L7ytm6K/nHK5sX+li5C63weNXxA7PMUjRUZ68KVg3H
         4MpfVVkUtChotcJpvYwHswTyc3cZkoGMk2IKA=
MIME-Version: 1.0
Received: by 10.213.13.20 with SMTP id z20mr2204858ebz.43.1302009829120; Tue,
 05 Apr 2011 06:23:49 -0700 (PDT)
Sender: patrick.allaert@gmail.com
Received: by 10.213.17.16 with HTTP; Tue, 5 Apr 2011 06:23:49 -0700 (PDT)
In-Reply-To: <4D9B03A9.1020600@php.net>
References: <4D99E241.4050100@php.net>
	<BANLkTinYMXVFbUq7LYSJw1-VSh=ibwSYjw@mail.gmail.com>
	<4D9AA9ED.2010102@php.net>
	<BANLkTinT4Jwo07YhmxHXoxkaMZHZdAi9FQ@mail.gmail.com>
	<4D9AF321.3020800@php.net>
	<BANLkTikzZgBh6mA_aM4brv-OVxbJfr+23w@mail.gmail.com>
	<4D9B03A9.1020600@php.net>
Date: Tue, 5 Apr 2011 15:23:49 +0200
X-Google-Sender-Auth: OaXiuob3fSVvPdeMIrS-VI_gJOI
Message-ID: <BANLkTinhOGpMjrH6aFAgMAgFP+77gqOfFg@mail.gmail.com>
To: internals@lists.php.net
Cc: Sebastian Bergmann <sebastian@php.net>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
Subject: Re: [PHP-DEV] Optional $limit argument for debug_backtrace()
From: patrickallaert@php.net (Patrick ALLAERT)

2011/4/5 Sebastian Bergmann <sebastian@php.net>:
> On 04/05/2011 01:12 PM, Patrick ALLAERT wrote:
>>
>> I would, however, refrain from providing erroneous reflection informatio=
n:
>>
>> php --rf debug_print_backtrace
>> Function [<internal:Core> =C2=A0function debug_print_backtrace ] {
>>
>> =C2=A0 - Parameters [2] {
>> =C2=A0 =C2=A0 Parameter #0 [<optional> =C2=A0$options ]
>> =C2=A0 =C2=A0 Parameter #1 [<optional> =C2=A0$limit ]
>> =C2=A0 }
>> }
>
> =C2=A0I did not touch debug_print_backtrace().

Yes, you did (or plan to) :)

Both debug_backtrace() and debug_print_backtrace() uses
arginfo_debug_backtrace which you modified to include the "limit"
parameter:

 ZEND_BEGIN_ARG_INFO_EX(arginfo_debug_backtrace, 0, 0, 0)
     ZEND_ARG_INFO(0, options)
+    ZEND_ARG_INFO(0, limit)
 ZEND_END_ARG_INFO()

Patrick