Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:51819
Return-Path: <patrick.allaert@gmail.com>
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Delivered-To: mailing list internals@lists.php.net
Received: (qmail 84700 invoked from network); 5 Apr 2011 11:12:58 -0000
Received: from unknown (HELO lists.php.net) (127.0.0.1)
  by localhost with SMTP; 5 Apr 2011 11:12:58 -0000
Authentication-Results: pb1.pair.com smtp.mail=patrick.allaert@gmail.com; spf=pass; sender-id=pass
Authentication-Results: pb1.pair.com header.from=patrick.allaert@gmail.com; sender-id=pass; domainkeys=bad
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.215.170 as permitted sender)
DomainKey-Status: bad
X-DomainKeys: Ecelerity dk_validate implementing draft-delany-domainkeys-base-01
X-PHP-List-Original-Sender: patrick.allaert@gmail.com
X-Host-Fingerprint: 209.85.215.170 mail-ey0-f170.google.com  
Received: from [209.85.215.170] ([209.85.215.170:52311] helo=mail-ey0-f170.google.com)
	by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP
	id 4F/57-37955-839FA9D4 for <internals@lists.php.net>; Tue, 05 Apr 2011 07:12:57 -0400
Received: by eyf5 with SMTP id 5so69634eyf.29
        for <internals@lists.php.net>; Tue, 05 Apr 2011 04:12:53 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=gamma;
        h=domainkey-signature:mime-version:sender:in-reply-to:references:date
         :x-google-sender-auth:message-id:subject:from:to:cc:content-type
         :content-transfer-encoding;
        bh=wGscxMrrvqrhYc+6PHjMzuvsumXb0Kob0dIwV1tSFq8=;
        b=cMrb6RLXN4zSZWgh3ORQeuEKjJaVRZ8sqNxPZUv15nfhSjqlYg6snbcfuXpNZRaARp
         X7YARn5XeEMaNjrhkP4ZZghduIfxDNb9FRjltGQTIf/f8se7e3SeP1cs9edgbbZ+t5n2
         ghSy6LDMX79+Y3ufNNyVHs4/OjNtCARpccMvk=
DomainKey-Signature: a=rsa-sha1; c=nofws;
        d=gmail.com; s=gamma;
        h=mime-version:sender:in-reply-to:references:date
         :x-google-sender-auth:message-id:subject:from:to:cc:content-type
         :content-transfer-encoding;
        b=mqf48cwDWi1iVPVuMATjj+oclGsTSN1KGsFfBJl9aglJLOv3n2cS8bl5HMdZYU/rpy
         pigEhptOxLmzchVg8rK50n828AOpeB6+oJacc8CMhvq8Z+e4ERsmscE7Znw0As8U8BiL
         4sGkRKoEGKZeDEUIwwICvEDay2Fh4u+NdkcgI=
MIME-Version: 1.0
Received: by 10.213.109.74 with SMTP id i10mr2078761ebp.5.1302001973512; Tue,
 05 Apr 2011 04:12:53 -0700 (PDT)
Sender: patrick.allaert@gmail.com
Received: by 10.213.17.16 with HTTP; Tue, 5 Apr 2011 04:12:53 -0700 (PDT)
In-Reply-To: <4D9AF321.3020800@php.net>
References: <4D99E241.4050100@php.net>
	<BANLkTinYMXVFbUq7LYSJw1-VSh=ibwSYjw@mail.gmail.com>
	<4D9AA9ED.2010102@php.net>
	<BANLkTinT4Jwo07YhmxHXoxkaMZHZdAi9FQ@mail.gmail.com>
	<4D9AF321.3020800@php.net>
Date: Tue, 5 Apr 2011 13:12:53 +0200
X-Google-Sender-Auth: 8Q_hy0mGp_QTmiMCBv_myk2__Hg
Message-ID: <BANLkTikzZgBh6mA_aM4brv-OVxbJfr+23w@mail.gmail.com>
To: internals@lists.php.net
Cc: Sebastian Bergmann <sebastian@php.net>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
Subject: Re: [PHP-DEV] Optional $limit argument for debug_backtrace()
From: patrickallaert@php.net (Patrick ALLAERT)

2011/4/5 Sebastian Bergmann <sebastian@php.net>:
> On 04/05/2011 12:39 PM, Patrick ALLAERT wrote:
>>
>> They share nothing in terms of code
>
> =C2=A0Question is: should debug_print_backtrace() not be refactored to re=
use
> =C2=A0code from zend_fetch_debug_backtrace()? That is why did not touch i=
t
> =C2=A0yet.

+1
I greatly share the refactoring need, I will see how this could be
done while providing as much internal API as possible so that
extension can benefit of.
I would, however, refrain from providing erroneous reflection information:

php --rf debug_print_backtrace
Function [ <internal:Core> function debug_print_backtrace ] {

  - Parameters [2] {
    Parameter #0 [ <optional> $options ]
    Parameter #1 [ <optional> $limit ]
  }
}

Patrick