Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:51738 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 54655 invoked from network); 22 Mar 2011 05:06:39 -0000 Received: from unknown (HELO lists.php.net) (127.0.0.1) by localhost with SMTP; 22 Mar 2011 05:06:39 -0000 X-Host-Fingerprint: 200.66.23.202 unknown Received: from [200.66.23.202] ([200.66.23.202:19956] helo=localhost.localdomain) by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP id 92/00-54529-D5E288D4 for ; Tue, 22 Mar 2011 00:06:38 -0500 Message-ID: <92.00.54529.D5E288D4@pb1.pair.com> To: internals@lists.php.net Content-Type: text/plain; charset="ISO-8859-1" Date: Mon, 21 Mar 2011 23:06:28 -0600 Content-Transfer-Encoding: 7Bit References: Followup-To: php.internals Lines: 19 MIME-Version: 1.0 X-Posted-By: 200.66.23.202 Subject: Re: [PHP-DEV] embedded libmagic (from file) From: geissert@php.net (Raphael Geissert) Scott MacVicar wrote: > I have a diff sitting that I did yesterday that upgrades us to the > latest libmagic, it supports the new magic file format and updates > that bundle. But that's all. > > I'm also against allowing the non-php version. Yes it's a fork but > unfortunately it's for the best. Last time I checked there were some general bug fixes (e.g. fixing type casting) that were not in upstream's version. Were they forwarded for 5.05? (I haven't personally checked) It's easy to understand the wish of hacking libmagic to provide some more features, but it would be great to keep the divergence to the strict minimum. Cheers, -- Raphael Geissert