Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:51732 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 31864 invoked from network); 20 Mar 2011 03:31:01 -0000 Received: from unknown (HELO lists.php.net) (127.0.0.1) by localhost with SMTP; 20 Mar 2011 03:31:01 -0000 Authentication-Results: pb1.pair.com smtp.mail=smalyshev@sugarcrm.com; spf=pass; sender-id=pass Authentication-Results: pb1.pair.com header.from=smalyshev@sugarcrm.com; sender-id=pass Received-SPF: pass (pb1.pair.com: domain sugarcrm.com designates 207.97.245.153 as permitted sender) X-PHP-List-Original-Sender: smalyshev@sugarcrm.com X-Host-Fingerprint: 207.97.245.153 smtp153.iad.emailsrvr.com Linux 2.6 Received: from [207.97.245.153] ([207.97.245.153:49521] helo=smtp153.iad.emailsrvr.com) by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP id B8/63-18282-3F4758D4 for ; Sat, 19 Mar 2011 22:31:00 -0500 Received: from localhost (localhost.localdomain [127.0.0.1]) by smtp45.relay.iad1a.emailsrvr.com (SMTP Server) with ESMTP id 475EB901A2; Sat, 19 Mar 2011 23:30:57 -0400 (EDT) X-Virus-Scanned: OK Received: by smtp45.relay.iad1a.emailsrvr.com (Authenticated sender: smalyshev-AT-sugarcrm.com) with ESMTPSA id B7FF390198; Sat, 19 Mar 2011 23:30:56 -0400 (EDT) Message-ID: <4D8574EF.60003@sugarcrm.com> Date: Sat, 19 Mar 2011 20:30:55 -0700 Organization: SugarCRM User-Agent: Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.6; en-US; rv:1.9.2.14) Gecko/20110221 Thunderbird/3.1.8 MIME-Version: 1.0 To: Tim Starling CC: internals Mailing List References: <4D803F21.1010209@wikimedia.org> <4D855DF2.8040702@wikimedia.org> In-Reply-To: <4D855DF2.8040702@wikimedia.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [PHP-DEV] [patch] Session RSHUTDOWN, shutdown_destructors() issues From: smalyshev@sugarcrm.com (Stas Malyshev) Hi! > I guess I'm suffering from some tl;dr here. Here's the short version: > please apply the attached patch to the 5.3 branch. It removes some > code which is broken and unnecessary. I'm not sure it's a good idea. That code is there for a reason, specifically: http://svn.php.net/viewvc?view=revision&revision=216213 Did you check that this test still works when you apply your patch? -- Stanislav Malyshev, Software Architect SugarCRM: http://www.sugarcrm.com/ (408)454-6900 ext. 227