Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:51692
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.214.170 as permitted sender)
DomainKey-Status: bad
DomainKey-Signature: a=rsa-sha1; c=nofws;
        d=gmail.com; s=gamma;
        h=mime-version:in-reply-to:references:from:date:message-id:subject:to
         :cc:content-type:content-transfer-encoding;
        b=EfS8lWMOP5osGn3bu/HK4D3A1DDnHtwxayw4EXMSxMvbt6fEE7e9g+b/fsWnDbkTb0
         /UsQN5OvG7kK26AebAW7LZBU5tUm149901EJf/z/CXv9JLQKe/L6EiGugQ1hsCJqDk8Z
         db408di+Hzcr5MCBlqrVbBoyqzOnofNLefTOk=
MIME-Version: 1.0
In-Reply-To: <54.6B.10215.BC23F7D4@pb1.pair.com>
References: <AANLkTinkpzJAWMF1fxUrFVHz0j5ZvjBt_vPT4_f-=2vo@mail.gmail.com>
 <20110313213928.GD4446@crousti> <AANLkTimwFNE+uucV==2iyXM40Y3A+DYKRKQbkuw3+VG9@mail.gmail.com>
 <54.6B.10215.BC23F7D4@pb1.pair.com>
Date: Tue, 15 Mar 2011 10:01:26 +0000
Message-ID: <AANLkTin_h0vA2Kxd8bSAD9O0C7SMvbZf8UyyuD6hxr4z@mail.gmail.com>
To: Nick Pope <php@nickpope.me.uk>
Cc: internals@lists.php.net
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: quoted-printable
Subject: Re: [PHP-DEV] SplFileObject Countable
From: petercowburn@gmail.com (Peter Cowburn)

Hi all,

On 15 March 2011 09:35, Nick Pope <php@nickpope.me.uk> wrote:
> Hi Sebastian,
>
> Since Etienne brought it up, would it not also make sense for you to
> implement countWords() and countBytes()?

For countBytes() how is that different from SplFileInfo's getSize() ?
As for countWords() and the others, I think this crosses the line (in
my view) over what a "File Object" should provide.

>
> Also, unicode issues aside, it might still be nice to implement
> countChars().
>
> And finally, so that it provides all most of the functionality of the GNU=
 wc
> program, there could also be getMaxLineLength(). =A0This would need a
> different name however as this method would be to count the longest line =
of
> the file rather than indicate the maximum length of a line to read as the
> current SplFileObject::getMaxLineLen() method does.
>
> Just my thoughts,
>
> Nick
>
>
> On 14/03/11 22:24, Sebastian Marek wrote:
>>
>> Hello,
>>
>> That makes perfect sense. I have raised a feature request and have
>> attached
>> a patch containing both countLines() method implementation and phpt test=
s.

Having not looked at the implementation yet, I have no comments on the
patch itself. However, I would prefer a "get" prefixed method name,
getLineCount() or similar.

>>
>> thx
>>
>> On Sun, Mar 13, 2011 at 9:39 PM, Etienne Kneuss<colder@php.net> =A0wrote=
:
>>
>>> On Mar 11 23:22:04, Sebastian Marek wrote:
>>>>
>>>> Hi,
>>>>
>>>> I have recently used SplFileObject to work with files. I was lacking a
>>>
>>> bit
>>>>
>>>> of functionality in there regarding counting number of lines in a give=
n
>>>> file. Although I could just load contents of the file to an array and
>>>
>>> check
>>>>
>>>> it size, I thought it would be nice to have SplFileObject Countable.
>>>>
>>>> Here is an example implementation I made tonight that seems to work we=
ll
>>>
>>> -
>>>>
>>>> https://gist.github.com/866767 . Is it something you think would be
>>>
>>> worth
>>>>
>>>> adding to the existing SplFileObject? Is the implementation any good? =
I
>>>> reused some of the existing logic to avoid breaking
>>>
>>> 'spl_filesystem_object'
>>>>
>>>> internal integrity, but maybe it would make sense to make it work with
>>>
>>> the
>>>>
>>>> stream itself.
>>>
>>> In my oppinion, it does not make sense to implement countable for this
>>> use. Countable should be implemented on classes where calling count() o=
n
>>> them is not ambiguous, i.e. the size of a collection.
>>>
>>> There is no reason why count() on a file should be the number of lines,
>>> why not words, or bytes?
>>>
>>> I'd however be happy with a new countLines() method.
>>>
>>> Best,
>>>
>>>>
>>>> If it's fine I can write some unit tests to cover this and then submit=
 a
>>>> complete patch.
>>>>
>>>> Regards
>>>> --
>>>> Sebastian Marek
>>>> proofek@gmail.com
>>>>
>>>> Follow me online at:
>>>> Blog: http://criticallog.thornet.net/
>>>> Twitter: http://twitter.com/proofek
>>>> Linkedin: http://uk.linkedin.com/in/sebastianmarek
>>>> Ohloh: http://www.ohloh.net/accounts/proofek
>>>> <http://twitter.com/proofek>
>>>
>>
>>
>>
>
>
> --
> PHP Internals - PHP Runtime Development Mailing List
> To unsubscribe, visit: http://www.php.net/unsub.php
>
>