Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:51689
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.216.42 as permitted sender)
DomainKey-Status: bad
DomainKey-Signature: a=rsa-sha1; c=nofws;
        d=gmail.com; s=gamma;
        h=mime-version:in-reply-to:references:date:message-id:subject:from:to
         :cc:content-type;
        b=o1YkGZlpxApRKL8PFrbsP7QnoCr2EyXvbB3eC75bWyJAhG886EY0QAwyUn1q5V57qC
         S21TkeCwOyNfKkfSlmX7wETLytQyLDQbKAlse5xIFJmOuNzdQfwbTJQvtxYCaXjzZfiD
         6MiJ62/r2Vs/5+qQBD/3ctyvF9z1d84E2M6EU=
MIME-Version: 1.0
In-Reply-To: <20110313213928.GD4446@crousti>
References: <AANLkTinkpzJAWMF1fxUrFVHz0j5ZvjBt_vPT4_f-=2vo@mail.gmail.com>
	<20110313213928.GD4446@crousti>
Date: Mon, 14 Mar 2011 22:24:09 +0000
Message-ID: <AANLkTimwFNE+uucV==2iyXM40Y3A+DYKRKQbkuw3+VG9@mail.gmail.com>
To: Etienne Kneuss <colder@php.net>
Cc: internals@lists.php.net
Content-Type: multipart/alternative; boundary=00235429d2bc407b50049e78c509
Subject: Re: [PHP-DEV] SplFileObject Countable
From: proofek@gmail.com (Sebastian Marek)

--00235429d2bc407b50049e78c509
Content-Type: text/plain; charset=UTF-8

Hello,

That makes perfect sense. I have raised a feature request and have attached
a patch containing both countLines() method implementation and phpt tests.

thx

On Sun, Mar 13, 2011 at 9:39 PM, Etienne Kneuss <colder@php.net> wrote:

> On Mar 11 23:22:04, Sebastian Marek wrote:
> > Hi,
> >
> > I have recently used SplFileObject to work with files. I was lacking a
> bit
> > of functionality in there regarding counting number of lines in a given
> > file. Although I could just load contents of the file to an array and
> check
> > it size, I thought it would be nice to have SplFileObject Countable.
> >
> > Here is an example implementation I made tonight that seems to work well
> -
> > https://gist.github.com/866767 . Is it something you think would be
> worth
> > adding to the existing SplFileObject? Is the implementation any good? I
> > reused some of the existing logic to avoid breaking
> 'spl_filesystem_object'
> > internal integrity, but maybe it would make sense to make it work with
> the
> > stream itself.
>
> In my oppinion, it does not make sense to implement countable for this
> use. Countable should be implemented on classes where calling count() on
> them is not ambiguous, i.e. the size of a collection.
>
> There is no reason why count() on a file should be the number of lines,
> why not words, or bytes?
>
> I'd however be happy with a new countLines() method.
>
> Best,
>
> >
> > If it's fine I can write some unit tests to cover this and then submit a
> > complete patch.
> >
> > Regards
> > --
> > Sebastian Marek
> > proofek@gmail.com
> >
> > Follow me online at:
> > Blog: http://criticallog.thornet.net/
> > Twitter: http://twitter.com/proofek
> > Linkedin: http://uk.linkedin.com/in/sebastianmarek
> > Ohloh: http://www.ohloh.net/accounts/proofek
> > <http://twitter.com/proofek>
>



-- 
Sebastian Marek
proofek@gmail.com

Follow me online at:
Blog: http://criticallog.thornet.net/
Twitter: http://twitter.com/proofek
Linkedin: http://uk.linkedin.com/in/sebastianmarek
Ohloh: http://www.ohloh.net/accounts/proofek
<http://twitter.com/proofek>

--00235429d2bc407b50049e78c509--