Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:51684
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.161.42 as permitted sender)
DomainKey-Status: bad
DomainKey-Signature: a=rsa-sha1; c=nofws;
        d=gmail.com; s=gamma;
        h=mime-version:in-reply-to:references:from:date:message-id:subject:to
         :cc:content-type:content-transfer-encoding;
        b=JnbVAu1UeUA89+awqm/E4jwKHudtD/3YkbOrKLK86YQyOqnSxs6Cu5MPMPUuKMAyxE
         GTTaHBC0KVmZJWJ77YoXRnhMf71Isop9jHjb39kYXWml52yuDygY++Qb8VR9kmjjzh8s
         5sgqLdkaDX+qyFHG0hW/jH0jOYOYNkdJY7h54=
MIME-Version: 1.0
In-Reply-To: <AANLkTin9P6us47ZH03EFK5RsoMoRHASbyq2OHo7d2Vtu@mail.gmail.com>
References: <AANLkTimkwFTD+Da2FhORfqJvT2WAXBni=SY5QLFZ+8Y8@mail.gmail.com>
 <20110313213356.GC4446@crousti> <AANLkTikbR7Wz9r4c0YCcwLp8+zMunhOBP9O5_KV54HWC@mail.gmail.com>
 <20110313215222.GE4446@crousti> <AANLkTimhyMo535YU_AC7Cm-cj5ACA4Q_8=cEfTTRLk5_@mail.gmail.com>
 <AANLkTin9P6us47ZH03EFK5RsoMoRHASbyq2OHo7d2Vtu@mail.gmail.com>
Date: Mon, 14 Mar 2011 15:02:27 -0300
Message-ID: <AANLkTikXHiq6DWegx8=5eBnZdS0DAzfZyD0quYitTfaR@mail.gmail.com>
To: Pierre Joye <pierre.php@gmail.com>
Cc: Marcelo Gornstein <marcelog@gmail.com>, Etienne Kneuss <colder@php.net>, internals@lists.php.net
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
Subject: Re: [PHP-DEV] native php annotations
From: guilhermeblanco@gmail.com ("guilhermeblanco@gmail.com")

Hi all,

I promise myself to not revamp this discussion again, but it wasn't me
this time!

@Etienne: That RFC is outdated.
Since the last feedback form internals list, a lot of changes have
been made to that RFC. Maybe I should update it ASAP so you can
clearly understand what have changed to be compatible with current PHP
syntax.

If you are interested, Pierrick moved all the recent developments to a
github repository, which can be reached here:
https://github.com/adoy/PHP-Annotations

Take a look at some tests:
https://github.com/adoy/PHP-Annotations/blob/master/tests/annotations/parse=
r_021.phpt
https://github.com/adoy/PHP-Annotations/blob/master/tests/annotations/Refle=
ctionParameter_getAnnotations_003.phpt
https://github.com/adoy/PHP-Annotations/blob/master/tests/annotations/Refle=
ctionClass_getAnnotations_004.phpt

Also, there's even an alternative patch that support positioned
parameters instead of named ones.
We just have to reach an agreement with what PHP core want.

@Marcelo: While your proposal looks very good, it lacks of the support
to nested Annotation.
Consider how userland/framework would use your idea. For example,
Symfony2 supports validation of data inside classes inspired on
JSR-303 (Bean Validation).

Symfony2 takes an advantage of a library Doctrine group (which I'm a
core member) created by parsing docblocks. When we created this
parser, I created this RFC with the good intention that PHP could
benefit of this known feature to enhance current userland
developments.
The first thing you need is your application still running ok with and
without comments. This already breaks all suggestions of creating a
PECL extension of docblock parser.



I'd like to see what people think about it and make something "IN" on
next PHP major version.



Cheers,

On Sun, Mar 13, 2011 at 8:07 PM, Pierre Joye <pierre.php@gmail.com> wrote:
> On Sun, Mar 13, 2011 at 11:02 PM, Marcelo Gornstein <marcelog@gmail.com> =
wrote:
>>> I don't believe the patch was anywhere near an accepted state back then=
,
>>> sadly.
>> Are you saying there wont be annotations in PHP? Is there any way to
>> contribute to make this feature accepted and available?
>
> No, only that no compromise has been reached on annotation support.
>
>
> --
> Pierre
>
> @pierrejoye | http://blog.thepimp.net | http://www.libgd.org
>
> --
> PHP Internals - PHP Runtime Development Mailing List
> To unsubscribe, visit: http://www.php.net/unsub.php
>
>



--=20
Guilherme Blanco
Mobile: +55 (16) 9215-8480
MSN: guilhermeblanco@hotmail.com
S=C3=A3o Paulo - SP/Brazil