Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:51633 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 94717 invoked from network); 9 Mar 2011 14:28:03 -0000 Received: from unknown (HELO lists.php.net) (127.0.0.1) by localhost with SMTP; 9 Mar 2011 14:28:03 -0000 Authentication-Results: pb1.pair.com header.from=landeholm@gmail.com; sender-id=pass; domainkeys=bad Authentication-Results: pb1.pair.com smtp.mail=landeholm@gmail.com; spf=pass; sender-id=pass Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.214.170 as permitted sender) DomainKey-Status: bad X-DomainKeys: Ecelerity dk_validate implementing draft-delany-domainkeys-base-01 X-PHP-List-Original-Sender: landeholm@gmail.com X-Host-Fingerprint: 209.85.214.170 mail-iw0-f170.google.com Received: from [209.85.214.170] ([209.85.214.170:35597] helo=mail-iw0-f170.google.com) by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP id 76/61-21312-F6E877D4 for ; Wed, 09 Mar 2011 09:28:00 -0500 Received: by iwn3 with SMTP id 3so587717iwn.29 for ; Wed, 09 Mar 2011 06:27:55 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:in-reply-to:references:date :message-id:subject:from:to:content-type; bh=1PrqKemxd3CRWWnOvu8PjMDFANVy4dEqZEZnICXi9W8=; b=uZW1YAqWtb+Q/k+gpkdRgSkUQ6iutyMzLsUWqvRtedbP8bdi7GDh0Cp3dgTm4OrGDX GZxrxlTMnrdanE6GAHTC84f7X/uVs8cT/KWWCD3KAAETPjJj7mHX93fGW/VvQoCm6aaa 9vLvx9eVTDg0F8prR0q0yefe1DrhbbntNT/hQ= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :content-type; b=NrLoBW3jR1zfmmr4+mTzNgkjzKF/7UTuQnpzgVOdufGq+18p2thKDzq32B6c3VVJFa H6qQiwxsVpjePXltxiRTffja3I2WJLTGwL4K7xTdPif8SBvj7RvtA93GX3mf7bT3T/l0 XVDu433FdnJcxyCRzxjrEWeueQZTwv+OxqvDE= MIME-Version: 1.0 Received: by 10.231.33.193 with SMTP id i1mr4882034ibd.199.1299680875812; Wed, 09 Mar 2011 06:27:55 -0800 (PST) Received: by 10.231.17.68 with HTTP; Wed, 9 Mar 2011 06:27:55 -0800 (PST) In-Reply-To: References: <4D7629B5.4090007@php.net> <4D76D849.6000103@gmail.com> Date: Wed, 9 Mar 2011 15:27:55 +0100 Message-ID: To: Martin Scotta , internals@lists.php.net Content-Type: multipart/alternative; boundary=002215048b6bec9742049e0d884d Subject: Re: [PHP-DEV] Make set_time_limit() timeout a catchable fatal error From: landeholm@gmail.com (Hannes Landeholm) --002215048b6bec9742049e0d884d Content-Type: text/plain; charset=ISO-8859-1 I'm personally a fan of errors and well defined return values. Exceptions doesn't solve any problem unless your problem is that your code is not enough spaghetti-ish. But I agree with "All fatal errors should be changed to catchable fatal errors". ~Hannes On 9 March 2011 15:18, Martin Scotta wrote: > Fatal error are most dumb feature in the language. > The are lot of "blind" areas where you don't know if you will ever > return... > > include "file.php"; > new Class(); > call_func(); > > All fatal errors should be changed to "catchable fatal errors" so > applications will be able to recover themselves... and if they don't catch > the error... then die. > > it would be nice if all errors could be changed into exceptions. > > Martin Scotta > > > > On Wed, Mar 9, 2011 at 10:56 AM, Hannes Landeholm wrote: > >> I second making time limit reached catchable. All non catchable fatal >> errors >> are a problem for me. I need to handle problems gracefully to ensure the >> stability of production systems instead of PHP just killing itself without >> warning. I just reported a similar issue: >> http://bugs.php.net/bug.php?id=54195 >> >> A simple way to implement this would be to register a function that would >> be >> called N seconds before the script would timeout. >> >> register_timeout_handler(2, function() { die("PHP timed out."); }); >> >> It would be called just as a shutdown function - in fact I'd like to use >> the >> same function as my shutdown function and get the error with >> error_get_last(). Of course set_time_limit(0) could be used in this >> function >> to prevent the timeout of the timeout handler. This does not "prevent" >> timeout since set_time_limit could have been called by the script before >> the >> timeout anyway. >> >> On that note I also miss a function which returns the time the script can >> keep running for. If that calculate needs to be calculated to implemented >> to >> implement this, why not make the value available to the PHP script? >> >> ~Hannes >> >> On 9 March 2011 02:30, David Muir wrote: >> >> > Although it doesn't let you recover from a timeout, you could use >> > register_shutdown_function to gracefully exit after a fatal error. >> > >> > register_shutdown_function(function(){ >> > $error = error_get_last(); >> > if($error && $error['type'] === E_ERROR){ >> > echo 'PHAIL! Oh noes, something went wrong!'; >> > // do whatever else you need to do before quitting >> > } >> > }); >> > >> > Cheers, >> > David >> > >> > On 08/03/11 22:39, Pierre Joye wrote: >> > > hi, >> > > >> > > is not the goal of this setting to prevent that a script runs longer >> > > than a given time? A catchable error will prevent that to happen. >> > > >> > > On Tue, Mar 8, 2011 at 2:05 PM, Sebastian Bergmann > > >> > wrote: >> > >> Could set_time_limit() be changed in such a way that it triggers a >> > >> catchable fatal error instead of a fatal error? Thanks! >> > >> >> > >> -- >> > >> Sebastian Bergmann Co-Founder and Principal >> > Consultant >> > >> http://sebastian-bergmann.de/ >> > http://thePHP.cc/ >> > >> >> > >> -- >> > >> PHP Internals - PHP Runtime Development Mailing List >> > >> To unsubscribe, visit: http://www.php.net/unsub.php >> > >> >> > >> >> > > >> > > >> > >> > >> > -- >> > PHP Internals - PHP Runtime Development Mailing List >> > To unsubscribe, visit: http://www.php.net/unsub.php >> > >> > >> > > --002215048b6bec9742049e0d884d--