Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:51591
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: error (pb1.pair.com: domain nebm.ist.utl.pt from 193.136.128.21 cause and error)
Content-Type: text/plain; charset=utf-8; format=flowed; delsp=yes
To: internals@lists.php.net
References: <43.60.54597.484527D4@pb1.pair.com> <op.vrv0tjvjidpuyk@cataphract>
 <4D7436E8.7010802@sugarcrm.com> <op.vryung0uidpuyk@clk-0081.clk-domain>
 <4D74A2E0.3090304@sugarcrm.com>
Date: Mon, 07 Mar 2011 09:40:11 -0000
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Organization: =?utf-8?Q?N=C3=BAcleo_de_Eng=2E_Biom=C3=A9di?=
 =?utf-8?Q?ca_do_I=2ES=2ET=2E?=
Message-ID: <op.vryvs9h6idpuyk@clk-0081.clk-domain>
In-Reply-To: <4D74A2E0.3090304@sugarcrm.com>
User-Agent: Opera Mail/11.01 (Win32)
Subject: Re: [PHP-DEV] [patch] allow socket_[gs]et_options() to work on
 streams
From: glopes@nebm.ist.utl.pt ("Gustavo Lopes")

Em Mon, 07 Mar 2011 09:18:24 -0000, Stas Malyshev <smalyshev@sugarcrm.com>  
escreveu:

>>> I think we already have PHP_STREAM_AS_SOCKETD, which should be
>>> appropriate here, not?
>>
>> That will indeed give you a socket descriptor, but
>> 1) it's not directly available to user-space.
>> 2) you still have to create a socket extension resource in order to pass
>> it to functions of that extension.
>
> Let socket functions deal with it - just see if it's a stream, use  
> AS_SOCKETD on it. They don't really need resource, they just need FD -  
> they'll get it one way or another.
>

That was indeed the original proposal, except it was limited to  
socket_get_option and socket_set_option.

In fact, the socket extension doesn't just need the file descriptor. Some  
functions also need to know whether the socket is in blocking mode and its  
type (AF_INET/AF_INET6/AF_UNIX/etc); see  
http://lxr.php.net/opengrok/xref/PHP_TRUNK/ext/sockets/php_sockets.h#82 .  
I suppose this information could be queried, but would you want to do the  
cast and retrieve this data in every call say in a socket_read loop?

I also don't think magically mixing PHP streams and socket resources is a  
good idea, users may start to think PHP streams and socket resources are  
interchangeable and will be (even more) confused when they can't use  
socket resources with the stream functions.


-- 
Gustavo Lopes