Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:51580
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain sugarcrm.com designates 67.192.241.163 as permitted sender)
Message-ID: <4D741CE4.7080508@sugarcrm.com>
Date: Sun, 06 Mar 2011 15:46:44 -0800
Organization: SugarCRM
User-Agent: Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.6; en-US; rv:1.9.2.14) Gecko/20110221 Thunderbird/3.1.8
MIME-Version: 1.0
To: Gustavo Lopes <glopes@nebm.ist.utl.pt>
CC: "internals@lists.php.net" <internals@lists.php.net>
References: <4D703FBC.3080006@sugarcrm.com> <op.vrt06asfidpuyk@cataphract-old.dulce.lo.geleia.net>
In-Reply-To: <op.vrt06asfidpuyk@cataphract-old.dulce.lo.geleia.net>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [PHP-DEV] streams problem in 5.3
From: smalyshev@sugarcrm.com (Stas Malyshev)

Hi!

> Can you tell what exactly you're doing? Why is there any cast in the first
> place?
>
> As far as I can see, the include should eventually call
> php_stream_open_for_zend_ex, which should give a ZEND_HANDLE_STREAM file
> handle that defers reading to _php_stream_read and fsize to
> php_zend_stream_fsizer, with no casting involved.

That's a regular include for file, however that one is actually a custom 
stream handler. I'm not sure yet what led for it to be converted to 
ZEND_HANDLE_FP, but if we're providing means to do that in the API, it 
sounds logical that the API shouldn't then require ZEND_HANDLE_FP to be 
pure file. I.e., if we already saying we're creating non-file FILE* in 
our code, then our code should be able to process it, shouldn't it?
-- 
Stanislav Malyshev, Software Architect
SugarCRM: http://www.sugarcrm.com/
(408)454-6900 ext. 227