Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:51578
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: error (pb1.pair.com: domain nebm.ist.utl.pt from 193.136.128.21 cause and error)
Content-Type: text/plain; charset=utf-8; format=flowed; delsp=yes
To: internals@lists.php.net
References: <43.60.54597.484527D4@pb1.pair.com>
Date: Sat, 05 Mar 2011 20:35:36 -0000
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Organization: =?utf-8?Q?N=C3=BAcleo_de_Eng=2E_Biom=C3=A9di?=
 =?utf-8?Q?ca_do_IST?=
Message-ID: <op.vrv0tjvjidpuyk@cataphract>
In-Reply-To: <43.60.54597.484527D4@pb1.pair.com>
User-Agent: Opera Mail/11.01 (Win32)
Subject: Re: [PHP-DEV] [patch] allow socket_[gs]et_options() to work on
 streams
From: glopes@nebm.ist.utl.pt ("Gustavo Lopes")

On Sat, 05 Mar 2011 15:19:31 -0000, Vincent NEGRIER  
<vnegrier@optilian.com> wrote:

> The goal of this patch is to allow user handling of low level socket  
> options for stream sockets created with stream_socket_*() or fsockopen()  
> functions.
>
> I choose to extend the socket_get_options() and socket_set_options()  
> functions and keep the functionality inside the sockets extension so  
> this won't add seldom used "bloat" to streams if built without it.
>
> With the patch, these two functions check if their first argument is a  
> stream, and then attempt to cast it to php_sock before trying to fetch  
> it as a socket resource.
>
> Patch is here: http://si.kz/php-sockets-stream-options.diff.txt
>
> Anyone with karma care to comment / commit ? :)
>

I think a better option would be a function to convert a php socket stream  
into a socket resource. That would avoid limiting this to  
socket_get_options/socket_set_options and polluting the socket ext  
functions prologue with these conversions.

And of course, in the long run, the socket streams should support all the  
operations the socket extension currently does.

As to your patch, just by a quick glance, you ought to at least check if  
the stream represents a socket (see php_stream_is). You also seem to be  
leaking php_sock and should add some tests. But again, I see this as a  
more inconsistent and limited approach.

-- 
Gustavo Lopes