Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:51570
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: error (pb1.pair.com: domain nebm.ist.utl.pt from 193.136.128.22 cause and error)
Content-Type: text/plain; charset=utf-8; format=flowed; delsp=yes
To: internals@lists.php.net
References: <4D703FBC.3080006@sugarcrm.com>
Date: Fri, 04 Mar 2011 18:48:04 -0000
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Organization: =?utf-8?Q?N=C3=BAcleo_de_Eng=2E_Biom=C3=A9di?=
 =?utf-8?Q?ca_do_IST?=
Message-ID: <op.vrt06asfidpuyk@cataphract-old.dulce.lo.geleia.net>
In-Reply-To: <4D703FBC.3080006@sugarcrm.com>
User-Agent: Opera Mail/11.01 (Win32)
Subject: Re: [PHP-DEV] streams problem in 5.3
From: glopes@nebm.ist.utl.pt ("Gustavo Lopes")

On Fri, 04 Mar 2011 01:26:20 -0000, Stas Malyshev <smalyshev@sugarcrm.com>  
wrote:

> I try to do some complex code with custom streams and I have discovered  
> the following problem:
>
> The code in main/streams/cast.c, specifically _php_stream_cast, creates  
> fopencookie() synthetic stream for streams that are not actual file  
> streams. Which works fine until such stream is used in include(), in  
> which case it ultimately arrives at zend_stream_fixup(). Which would in  
> turn call zend_stream_fsize() - which would do  
> fstat(fileno(file_handle->handle.fp), &buf) - and that would fail since  
> you can't get fileno for FILE* created by fopencookie.
> Which ultimately means I can't use my custom streams for include(),  
> which is bad. Now, looking at the code, it doesn't actually need the  
> exact size - http streams can be included just fine - but insists on  
> having it if it has fp (which it can have for basically any kind of  
> stream due to the cookie trick). Does anyone has any idea why and if it  
> can be fixed?

Can you tell what exactly you're doing? Why is there any cast in the first  
place?

As far as I can see, the include should eventually call  
php_stream_open_for_zend_ex, which should give a ZEND_HANDLE_STREAM file  
handle that defers reading to _php_stream_read and fsize to  
php_zend_stream_fsizer, with no casting involved.

-- 
Gustavo Lopes