Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:51550
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.161.42 as permitted sender)
DomainKey-Status: bad
DomainKey-Signature: a=rsa-sha1; c=nofws;
        d=gmail.com; s=gamma;
        h=message-id:date:from:user-agent:mime-version:to:subject:references
         :in-reply-to:content-type:content-transfer-encoding;
        b=kX+TNX61NzpE3dPGPswhfvNVar/PuuitneYyAlTqQWmM6Lxs2L/hkf/YzHn1sr8Ii4
         8wj771J/Zw5hW8xDMC8810Fqz0cw/T+KjTUfcTH0jfTHCODs4Dd9h2cbBQQ9HWfJ9B5K
         G0PZzMwBsWQ4IdATipDOcy3llL4vDftSIbd/I=
Message-ID: <4D6ED0CE.4040304@gmail.com>
Date: Thu, 03 Mar 2011 00:20:46 +0100
User-Agent: Thunderbird
MIME-Version: 1.0
To: Stas Malyshev <smalyshev@sugarcrm.com>, 
 PHP Developers Mailing List <internals@lists.php.net>
References: <4D6A3A9C.50308@seld.be> <4D6AEB6E.1060704@sugarcrm.com>
In-Reply-To: <4D6AEB6E.1060704@sugarcrm.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Subject: Re: [PHP-DEV] Volnitsky substring search algo
From: keisial@gmail.com ("=?UTF-8?B?w4FuZ2VsIEdvbnrDoWxleg==?=")

Stas Malyshev wrote:
> Hi!
>
>> http://volnitsky.com/project/str_search/
>
> I'm not sure it'd be easy to integrate this into PHP codebase as-is,
> provided it relies on C++ standard libraries which PHP makes no use of
> (and thus potentially introduces a world of dependencies and
> complexities into the build process). I'm sure it can be re-done in
> pure standard C, then it can be tested in PHP and if it's better - I
> don't see why it can't be integrated.
>
Not really. It only uses std::search, which would be equivalent to the
current zend_memnstr(). And std::numeric_limits can be replaced with a
limits.h macro.
I'd be more concerned about the "only for little-endian platforms and
where access to misaligned W is allowed" remark. php is also available
for big endian architectures, but that seems easy. Some architecture
supported by php won't probably accept that, so it would also need some
configure test to disable it.