Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:51549
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.161.42 as permitted sender)
DomainKey-Status: bad
DomainKey-Signature: a=rsa-sha1; c=nofws;
        d=gmail.com; s=gamma;
        h=message-id:date:from:user-agent:mime-version:to:cc:subject
         :references:in-reply-to:content-type:content-transfer-encoding;
        b=paGYEDNY5NenO8o8o96n89zRpybskbRVAcnUQ+ox4qXA4lgGiuqzPet4FKIQuxOYJN
         C4vMpJV2Uq9tC2uwmohSjTyJf1017/m+Imtcsqw59E+N2lzXEG0fO/64ViztDbO83ZwW
         7hNTi2t/jsVnz8/teIcWepZnymaXdFgl/f3/s=
Message-ID: <4D6ECD36.1070804@gmail.com>
Date: Thu, 03 Mar 2011 00:05:26 +0100
User-Agent: Thunderbird
MIME-Version: 1.0
To: Moriyoshi Koizumi <mozo@mozo.jp>
CC: PHP Developers Mailing List <internals@lists.php.net>
References: <AANLkTinAt4ToUv-FtOeSjbw4Db9iFitE7VvRNZF8yNAc@mail.gmail.com>
In-Reply-To: <AANLkTinAt4ToUv-FtOeSjbw4Db9iFitE7VvRNZF8yNAc@mail.gmail.com>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Subject: Re: [PHP-DEV] RFC: built-in web server in CLI.
From: keisial@gmail.com ("=?ISO-8859-1?Q?=C1ngel_Gonz=E1lez?=")

Moriyoshi Koizumi wrote:
> Hi,
>
> Just to let you know that I wrote a RFC about built-in web server
> feature with which PHP can serve contents without a help of web
> servers.  That would be handy for development purpose.
>
> If interested, have a look at http://wiki.php.net/rfc/builtinwebserver .
>
> Regards,
> Moriyoshi
I like the idea.

Regarding the patch (https://gist.github.com/835698):
I don't see a switch to disable the internal parse on configure.

I'd expect the files to be on its own folder inside sapi, even being
able to
bundle them in a single binary.

Why is this needed on WIndows?

+ ADD_FLAG("LIBS_CLI", "ws2_32.lib");

Surely php will already link with the sockets library for its own functions.

The http parser code seems copied from https://github.com/ry/http-parser and
it may not be a good idea to modify it downstream, but it  seems to do more
things than strictly needed by php (eg. there are more methods than those a
php server would take use).
It also seems to be a hand-coded lexer, so that's much more verbose than a
set of rules.

The patch looks messy as it splits main in two functions, so it gets
hard to follow,
but is probably good overall.

The change from php_printf to printf in line 3988 looks wrong.

Any special reason to disable it on PHP_CLI_WIN32_NO_CONSOLE ?