Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:51536
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.214.42 as permitted sender)
DomainKey-Status: bad
DomainKey-Signature: a=rsa-sha1; c=nofws;
        d=gmail.com; s=gamma;
        h=mime-version:in-reply-to:references:date:message-id:subject:from:to
         :cc:content-type:content-transfer-encoding;
        b=kqWmzJsV7t29j/RKWbj46Q7vgaG1ldCXPj+oujisLXj1tk/q5q3z7qDppCkOFkYJpU
         Q1CMy7+007bKgqYwbmeLXR/AROeobQ+3DgTKyvD4LLH7CuimL0feUzf9ChBVYp196+It
         YcSlwmiWJQGtURUGUk0L99pbJ9CvJdwkp8OVs=
MIME-Version: 1.0
In-Reply-To: <ik80mj$m7v$1@dough.gmane.org>
References: <ik60ur$tag$1@dough.gmane.org>
	<ik6nn9$2gf$1@dough.gmane.org>
	<ik80mj$m7v$1@dough.gmane.org>
Date: Fri, 25 Feb 2011 12:29:01 +0100
Message-ID: <AANLkTinVpTmT0CvkG4EeWoxsNX_=fcgdD4uCfkBwoM7V@mail.gmail.com>
To: Carsten Wiedmann <carsten_sttgt@gmx.de>
Cc: internals@lists.php.net
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: quoted-printable
Subject: Re: [PHP-DEV] problem with header() and php trunk
From: pierre.php@gmail.com (Pierre Joye)

hi Carsten,

Thanks for the report and the patch (applied)!

Cheers,

On Fri, Feb 25, 2011 at 11:36 AM, Carsten Wiedmann <carsten_sttgt@gmx.de> w=
rote:
> Am 24.02.2011 23:56, schrieb Carsten Wiedmann:
>>
>> Oh, this only happens with trunk, but not with e.g 5.3.5. But just see
>> the difference:
>
> OK, this bug was introduced in r301263. It's removing +1 char while cutti=
ng
> LWS at the end of a header line.
>
> <<<PATCH
> Index: SAPI.c
> =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D
> --- SAPI.c =A0 =A0 =A0(Revision 308566)
> +++ SAPI.c =A0 =A0 =A0(Arbeitskopie)
> @@ -680,7 +680,7 @@
> =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0do {
> =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0header_line_len--;
> =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0} while(header_line_len &&
> isspace(header_line[header_line_len-1]));
> - =A0 =A0 =A0 =A0 =A0 =A0 =A0 header_line[--header_line_len]=3D'\0';
> + =A0 =A0 =A0 =A0 =A0 =A0 =A0 header_line[header_line_len]=3D'\0';
> =A0 =A0 =A0 =A0}
>
> =A0 =A0 =A0 =A0if (op =3D=3D SAPI_HEADER_DELETE) {
> PATCH;
>
> <<<TESTPHPT
> --TEST--
> header() function - LWS at end of field-value
> --GET--
>
> --FILE--
> <?php
> header('x-headertest: foo ');
> var_dump(headers_list());
> ?>
> --EXPECTREGEX--
> .*string\(17\) \"x-headertest: foo\".*
> TESTPHPT;
>
>
> BTW:
> PHP is removing LWS at the end of the field-value, but why is it not
> replacing LWS between the field-name: and field-value with one SP?
>
> Regards,
> Carsten
>
>
> --
> PHP Internals - PHP Runtime Development Mailing List
> To unsubscribe, visit: http://www.php.net/unsub.php
>
>



--=20
Pierre

@pierrejoye | http://blog.thepimp.net | http://www.libgd.org