Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:51535
Return-Path: <php-php-dev@m.gmane.org>
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Delivered-To: mailing list internals@lists.php.net
Received: (qmail 37640 invoked from network); 25 Feb 2011 10:36:27 -0000
Received: from unknown (HELO lists.php.net) (127.0.0.1)
  by localhost with SMTP; 25 Feb 2011 10:36:27 -0000
Authentication-Results: pb1.pair.com header.from=carsten_sttgt@gmx.de; sender-id=fail
Authentication-Results: pb1.pair.com smtp.mail=php-php-dev@m.gmane.org; spf=pass; sender-id=pass
Received-SPF: pass (pb1.pair.com: domain m.gmane.org designates 80.91.229.12 as permitted sender)
X-PHP-List-Original-Sender: php-php-dev@m.gmane.org
X-Host-Fingerprint: 80.91.229.12 lo.gmane.org Linux 2.6
Received: from [80.91.229.12] ([80.91.229.12:45353] helo=lo.gmane.org)
	by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP
	id EA/90-33691-326876D4 for <internals@lists.php.net>; Fri, 25 Feb 2011 05:36:22 -0500
Received: from list by lo.gmane.org with local (Exim 4.69)
	(envelope-from <php-php-dev@m.gmane.org>)
	id 1Psv1z-0005zi-OC
	for internals@lists.php.net; Fri, 25 Feb 2011 11:36:15 +0100
Received: from dslb-178-007-210-108.pools.arcor-ip.net ([178.7.210.108])
        by main.gmane.org with esmtp (Gmexim 0.1 (Debian))
        id 1AlnuQ-0007hv-00
        for <internals@lists.php.net>; Fri, 25 Feb 2011 11:36:15 +0100
Received: from carsten_sttgt by dslb-178-007-210-108.pools.arcor-ip.net with local (Gmexim 0.1 (Debian))
        id 1AlnuQ-0007hv-00
        for <internals@lists.php.net>; Fri, 25 Feb 2011 11:36:15 +0100
X-Injected-Via-Gmane: http://gmane.org/
To: internals@lists.php.net
Date: Fri, 25 Feb 2011 11:36:12 +0100
Lines: 44
Message-ID: <ik80mj$m7v$1@dough.gmane.org>
References: <ik60ur$tag$1@dough.gmane.org> <ik6nn9$2gf$1@dough.gmane.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=ISO-8859-15; format=flowed
Content-Transfer-Encoding: 7bit
X-Gmane-NNTP-Posting-Host: dslb-178-007-210-108.pools.arcor-ip.net
User-Agent: Mozilla/5.0 (Windows; U; Windows NT 6.1; de; rv:1.9.2.13) Gecko/20101207 Thunderbird/3.1.7
In-Reply-To: <ik6nn9$2gf$1@dough.gmane.org>
X-Antivirus: avast! (VPS 110224-1, 24.02.2011), Outbound message
X-Antivirus-Status: Clean
Subject: Re: [PHP-DEV] problem with header() and php trunk
From: carsten_sttgt@gmx.de (Carsten Wiedmann)

Am 24.02.2011 23:56, schrieb Carsten Wiedmann:
> Oh, this only happens with trunk, but not with e.g 5.3.5. But just see
> the difference:

OK, this bug was introduced in r301263. It's removing +1 char while 
cutting LWS at the end of a header line.

<<<PATCH
Index: SAPI.c
===================================================================
--- SAPI.c	(Revision 308566)
+++ SAPI.c	(Arbeitskopie)
@@ -680,7 +680,7 @@
  		do {
  			header_line_len--;
  		} while(header_line_len && isspace(header_line[header_line_len-1]));
-		header_line[--header_line_len]='\0';
+		header_line[header_line_len]='\0';
  	}
  	
  	if (op == SAPI_HEADER_DELETE) {
PATCH;

<<<TESTPHPT
--TEST--
header() function - LWS at end of field-value
--GET--

--FILE--
<?php
header('x-headertest: foo ');
var_dump(headers_list());
?>
--EXPECTREGEX--
.*string\(17\) \"x-headertest: foo\".*
TESTPHPT;


BTW:
PHP is removing LWS at the end of the field-value, but why is it not 
replacing LWS between the field-name: and field-value with one SP?

Regards,
Carsten