Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:51351 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 26071 invoked from network); 24 Jan 2011 19:54:24 -0000 Received: from unknown (HELO lists.php.net) (127.0.0.1) by localhost with SMTP; 24 Jan 2011 19:54:24 -0000 Authentication-Results: pb1.pair.com header.from=johannes@schlueters.de; sender-id=unknown Authentication-Results: pb1.pair.com smtp.mail=johannes@schlueters.de; spf=permerror; sender-id=unknown Received-SPF: error (pb1.pair.com: domain schlueters.de from 217.114.211.66 cause and error) X-PHP-List-Original-Sender: johannes@schlueters.de X-Host-Fingerprint: 217.114.211.66 ns.km36107.keymachine.de Solaris 10 (beta) Received: from [217.114.211.66] ([217.114.211.66:64683] helo=config.schlueters.de) by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP id FA/C3-07901-FE8DD3D4 for ; Mon, 24 Jan 2011 14:54:24 -0500 Received: from [192.168.2.189] (ppp-93-104-107-114.dynamic.mnet-online.de [93.104.107.114]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by config.schlueters.de (Postfix) with ESMTPSA id 0BA1D4B6B8; Mon, 24 Jan 2011 20:54:18 +0100 (CET) To: Michael Morris Cc: PHP Internals List In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Date: Mon, 24 Jan 2011 20:54:17 +0100 Message-ID: <1295898857.11915.35.camel@guybrush> Mime-Version: 1.0 X-Mailer: Evolution 2.30.2 Content-Transfer-Encoding: 7bit Subject: Re: [PHP-DEV] [RFC] Var_export tabbing From: johannes@schlueters.de (Johannes =?ISO-8859-1?Q?Schl=FCter?=) Hi, On Mon, 2011-01-24 at 13:26 -0500, Michael Morris wrote: > Anyway, var_export takes 2 arguments - the expression to be converted and > whether to return or echo it. I'd like to add a third, whether to use > spaces (default) or tabs for indentation While I'm not sure that's really needed: Why not a string parameter - then one could choose between 2 or 4 spaces and tabs. As var_Export is using smart_str this should be quite simple change to do :-) > For backwards compatibility null would mean uses spaces, and use 2 per > indentation. If set to true a tab character would be used. For BC the the key point is if it is omitted, since not passing a parameter is different from passing NULL (or any other value) johannes