Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:51262
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: error (pb1.pair.com: domain easen.co.uk from 74.125.82.170 cause and error)
Content-Type: multipart/mixed; boundary=Apple-Mail-13-890463293
Date: Thu, 13 Jan 2011 00:15:59 +0000
Message-ID: <44B48568-D359-4BF8-B9A5-E2A15C37A88F@easen.co.uk>
To: internals@lists.php.net
Mime-Version: 1.0 (Apple Message framework v1082)
Subject: [PATCH] Bug #53727	Inconsistent behavior of is_subclass_of with interfaces
From: marc@easen.co.uk (Marc Easen)

--Apple-Mail-13-890463293
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain;
	charset=us-ascii

Hello,

I have attached a patch to the following bug, but I believe the bug is =
incorrect...

If is_subclass_of() is used in conjunction with a interface it should =
always return false because it's not a class, it's an interface.

Test:
------
interface MyInterface {
    const TEST_CONSTANT =3D true;
}

class ParentClass implements MyInterface { }

class ChildClass extends ParentClass { }

echo (is_subclass_of('ChildClass', 'MyInterface') ? 'true' : 'false') . =
"\n";
echo (defined('ChildClass::TEST_CONSTANT') ? 'true' : 'false') . "\n";

echo (is_subclass_of('ParentClass', 'MyInterface') ? 'true' : 'false') . =
"\n";
echo (defined('ParentClass::TEST_CONSTANT') ? 'true' : 'false') . "\n";

Expected result:
----------------
false
true
false
true

Actual result:
--------------
true
true
false
true


--Apple-Mail-13-890463293
Content-Disposition: attachment;
	filename=subclass_patch.txt
Content-Type: text/plain;
	x-unix-mode=0644;
	name="subclass_patch.txt"
Content-Transfer-Encoding: quoted-printable

Index: ext/standard/tests/class_object/is_subclass_of_variation_002.phpt
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D
--- ext/standard/tests/class_object/is_subclass_of_variation_002.phpt	=
(revision 306670)
+++ ext/standard/tests/class_object/is_subclass_of_variation_002.phpt	=
(working copy)
@@ -80,6 +80,15 @@
       var_dump( is_subclass_of($object, $value) );
 };
=20
+
+// Bug #53727 - Inconsistent behavior of is_subclass_of with interfaces
+interface MyInterface {}
+class ParentClass implements MyInterface { }
+class ChildClass extends ParentClass { }
+echo "\nBug #53727\n";
+echo (is_subclass_of('ChildClass', 'MyInterface') ? 'true' : 'false') . =
"\n";
+echo (is_subclass_of('ParentClass', 'MyInterface') ? 'true' : 'false') =
. "\n";
+
 echo "Done";
 ?>
 --EXPECTF--
@@ -168,4 +177,8 @@
=20
 Arg value =20
 bool(false)
+
+Bug #53727
+false
+false
 Done
\ No newline at end of file
Index: Zend/zend_builtin_functions.c
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D
--- Zend/zend_builtin_functions.c	(revision 306670)
+++ Zend/zend_builtin_functions.c	(working copy)
@@ -855,6 +855,9 @@
 		retval =3D 0;
 	} else {
 		if (only_subclass) {
+			if ((*ce)->ce_flags & ZEND_ACC_INTERFACE) {
+				RETURN_FALSE;
+			}
 			if (!instance_ce) {
 				instance_ce =3D Z_OBJCE_P(obj)->parent;
 			} else {

--Apple-Mail-13-890463293
Content-Transfer-Encoding: 7bit
Content-Type: text/plain;
	charset=us-ascii



Kind Regards

Marc
--Apple-Mail-13-890463293--