Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:51218
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.216.177 as permitted sender)
DomainKey-Status: bad
DomainKey-Signature: a=rsa-sha1; c=nofws;
        d=gmail.com; s=gamma;
        h=mime-version:in-reply-to:references:date:message-id:subject:from:to
         :cc:content-type;
        b=fWb4V83onkvNADQPmNZhc/+zLBpEBUzq4T+n84GcX/nGx50Xvww4Dr8HwrXaPD8Qln
         /UkbtsLpBPQ9fFfim5hFcp9Mp5GzzLiHJvmYWxN4zvuT0zdl7XnIrA0yblK8odk+ei6c
         BOsQ2vi86pJltUn0BxswIexHZ1MAg6jh1XLiY=
MIME-Version: 1.0
In-Reply-To: <4D245F5B.3050707@yahoo.co.jp>
References: <4D245F5B.3050707@yahoo.co.jp>
Date: Wed, 5 Jan 2011 20:17:39 +0800
Message-ID: <AANLkTi=WdNOsdChnn-x-GeB2MRZM=Zho6sGuY=ho3ask@mail.gmail.com>
To: Rui Hirokawa <rui_hirokawa@yahoo.co.jp>
Cc: internals@lists.php.net
Content-Type: multipart/alternative; boundary=0015175cb8e40341580499185fca
Subject: Re: [PHP-DEV] [PATCH] adding RFC3984 support to http_build_query
From: tjerk.meesters@gmail.com (Tjerk Meesters)

--0015175cb8e40341580499185fca
Content-Type: text/plain; charset=ISO-8859-1

Instead of a boolean, could you add a rfc-xx selection parameter instead,
like, in case one would like rfc 3986 instead?
On Jan 5, 2011 8:10 PM, "Rui Hirokawa" <rui_hirokawa@yahoo.co.jp> wrote:
> Hello,
>
> I made a patch to add the RFC-3984 based url-encoding support
> into http_build_query().
>
> The http_build_query() is quite useful, but,
> it isn't based on the official url-encoding scheme (RFC-3984)
> for ~ (tilde) and ' '(space).
>
> I added an optional (the 4th) parameter 'is_rfc3984'.
> If it is true (false by default, now), RFC3984 based
> url-encoding scheme (it is same as rawurlencode() ) is used.
>
> A simple example shown as bellow,
>
> $v = array('foo'=>'m o','boo'=>'[^~]');
>
> // result: foo=m+p&boo=%5B%5E%7E5D
> echo http_build_query($v, null, '&');
>
> // result: foo=m%20p&boo=%5B%5E~5D (RFC-3986 compatible)
> echo http_build_query($v, null, '&', true);
>
> // result: foo=m%20p&boo=%5B%5E~5D (RFC-3986 compatible)
> echo rawurlencode($v['foo']).'&'.rawurlencode($v['boo']);
>
>
> I'm going to commit the patch if it is accepted.
>
> Rui

--0015175cb8e40341580499185fca--