Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:51141 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 92920 invoked from network); 28 Dec 2010 07:21:54 -0000 Received: from unknown (HELO lists.php.net) (127.0.0.1) by localhost with SMTP; 28 Dec 2010 07:21:54 -0000 Authentication-Results: pb1.pair.com header.from=tony@daylessday.org; sender-id=pass Authentication-Results: pb1.pair.com smtp.mail=tony@daylessday.org; spf=pass; sender-id=pass Received-SPF: pass (pb1.pair.com: domain daylessday.org designates 89.208.40.236 as permitted sender) X-PHP-List-Original-Sender: tony@daylessday.org X-Host-Fingerprint: 89.208.40.236 mail.daylessday.org Linux 2.6 Received: from [89.208.40.236] ([89.208.40.236:45520] helo=daylessday.org) by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP id 39/50-22572-D00991D4 for ; Tue, 28 Dec 2010 02:21:52 -0500 Received: from think.site (unknown [91.79.214.231]) by daylessday.org (Postfix) with ESMTPSA id 33158BFA07D; Tue, 28 Dec 2010 10:21:46 +0300 (MSK) Message-ID: <4D199014.8080207@daylessday.org> Date: Tue, 28 Dec 2010 10:21:56 +0300 User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.1.16) Gecko/20101125 SUSE/3.0.11 Thunderbird/3.0.11 MIME-Version: 1.0 To: internals@lists.php.net CC: =?UTF-8?B?Q3Jpc3RpYW4gUm9kcsOtZ3Vleg==?= References: <1293490245-16963-1-git-send-email-cristian.rodriguez@opensuse.org> In-Reply-To: <1293490245-16963-1-git-send-email-cristian.rodriguez@opensuse.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Subject: Re: [PHP-DEV] [PATCH] fix memory leak in fpm_conf_set_array() From: tony@daylessday.org (Antony Dovgal) On 12/28/2010 01:50 AM, Cristian Rodríguez wrote: - if (err) return err; + if (err) { free(kv); return err;} I believe the patch is a bit more complicated than that. Here is new version: http://dev.daylessday.org/diff/fpm_leaks.diff Could you test it please? -- Wbr, Antony Dovgal --- http://pinba.org - realtime statistics for PHP