Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:51075
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: error (pb1.pair.com: domain openmv.com from 64.15.152.204 cause and error)
To: "'Stefan Marr'" <php@stefan-marr.de>,
	"'Larry Garfield'" <larry@garfieldtech.com>
Cc: <internals@lists.php.net>
References: <89C52156-CF92-4DDB-8BA4-4ABF6883512C@stefan-marr.de> <AANLkTi=dz1pu7B+1k-xAbCRPmFx24J=27ABaWLRuPwqK@mail.gmail.com> <D9ED43A9-833E-4644-9DFC-DE89CF83656F@stefan-marr.de> <201012132027.59678.larry@garfieldtech.com> <76C593EE-BCCA-4BBD-B625-B6AE9340B20C@stefan-marr.de>
In-Reply-To: <76C593EE-BCCA-4BBD-B625-B6AE9340B20C@stefan-marr.de>
Date: Sat, 18 Dec 2010 12:14:15 -0500
Message-ID: <001501cb9ed7$001bcbd0$00536370$@com>
MIME-Version: 1.0
Content-Type: text/plain;
	charset="us-ascii"
Content-Transfer-Encoding: 7bit
Thread-Index: AcueyH23Y66vNzlFR/GOH0/jZZNyvAABWMew
Content-Language: en-ca
Subject: RE: [PHP-DEV] Traits and Properties
From: jbondc@openmv.com ("Jonathan Bond-Caron")

On Sat Dec 18 10:29 AM, Stefan Marr wrote:
> At least I do not find an argument for either way that completely 
> convinces me.
> At the moment, the main reason is that 'public' can be considered to 
> be the default visibility modifier.
> Based on the semantics of 'var' and dynamic properties.
> Thus, private tends to imply that an additional constraint was 
> consciously applied to the property, which should be preserved.
> Well, but as I said, thats kind of arbitrary and if you look at the 
> inheritance rules and try to reason from the view of clients with 
> respect to the external interface, then going with public as the 
> chosen modifier also starts to sound reasonable...
> 

Does the order of the declaration matter?

trait THello1 {
  public $foo;
}

trait THello2 {
  private $foo;
}

trait THello3 {
  protected $foo;
}

class TraitsTest {
	use THello1;
	use THello2; // E_NOTICE: TraitTest conflict, THello2(private $foo)
ignored, already declared THello1(public $foo)
	use THello3; // E_NOTICE: TraitTest conflict, THello3(protected
$foo) ignored, already declared THello1(public $foo)
}

class TraitsTest2 {
	use THello3;
	use THello2; // E_NOTICE: ..
	use THello1; // E_NOTICE: ..
}

It could be that the first property 'wins' and an E_NOTICE is raised about
the property conflict.

Result:

class TraitsTest {
  public $foo;
}

class TraitsTest2 {
  protected $foo;
}

It would seem to fit php, though I'd be happy with simply E_FATAL until
people start using traits

The same for:

trait THelloA {
  public $foo = 'a';
}
trait THelloB {
  public $foo = 'b';
}
class TraitsTest3 {
  use THelloA;
  use THelloB; // E_NOTICE: TraitTest3 conflict, THelloB(public $foo)
ignored, already declared THelloA(public $foo)
}

class TraitsTest4 {
  use THelloB;
  use THelloA; // E_NOTICE: TraitTest3 conflict, THelloA(public $foo)
ignored, already declared THelloB(public $foo)
}

class TraitsTest5 {
  public $foo = 'c';

  use THelloB; // E_NOTICE: TraitTest3 conflict, THelloB(public $foo)
ignored, already declared TraitsTest5(public $foo)
  use THelloA; // E_NOTICE: TraitTest3 conflict, THelloA(public $foo)
ignored, already declared THelloB(public $foo)
}