Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:50901
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 74.125.82.170 as permitted sender)
DomainKey-Status: bad
DomainKey-Signature: a=rsa-sha1; c=nofws;
        d=gmail.com; s=gamma;
        h=mime-version:in-reply-to:references:date:message-id:subject:from:to
         :cc:content-type;
        b=p0G/N5SgAvy3TcqN06Yj2GVTXPN38Y7CmKJ8NiRtnB6FgXhuThd0/j3FC69kzR2XRX
         VsY/1iT2DNaWMYBVfQ5qcAkYlamQBdzcvfBbyG41C7cTPempOqX2+ik3xZuyX2BTxDMp
         jUcSPgPnRZextySzZy4/svU0wlZz/BE2o9Z4Y=
MIME-Version: 1.0
In-Reply-To: <op.vnb0shjiidpuyk@damnation.dulce.lo.geleia.net>
References: <op.vnb0shjiidpuyk@damnation.dulce.lo.geleia.net>
Date: Tue, 7 Dec 2010 11:05:42 -0500
Message-ID: <AANLkTikmuxZw_NwFjoaWLmY7DT7YYLBT=wCcfK8ApVtb@mail.gmail.com>
To: Gustavo Lopes <glopes@nebm.ist.utl.pt>
Cc: "internals@lists.php.net" <internals@lists.php.net>
Content-Type: multipart/alternative; boundary=0016e6dab4df3959c40496d42de7
Subject: Re: [PHP-DEV] [PATCH] Add option to disable POST data processing
From: nicobn@gmail.com (=?ISO-8859-1?Q?Nicolas_A=2E_B=E9rard=2DNault?=)

--0016e6dab4df3959c40496d42de7
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: quoted-printable

Hi,

On Tue, Dec 7, 2010 at 2:08 AM, Gustavo Lopes <glopes@nebm.ist.utl.pt>wrote=
:

> The very simple attached patch adds an option to disable POST data
> processing, which implies the data can only be read in a stream fashion
> through php://input.
>
> As far as I know, PHP offers no way to inhibit processing RFC 1867 data a=
nd
> one has to use very hacky means to accomplish that. This is often require=
d
> (or at least convenient) in order to, e.g., proxy requests or handle file
> uploads in memory.
>
> For other types of requests, the default processing of POST data may also
> be a problem. Take a non-application/x-www-form-urlencoded POST requests
> (say, some kind of RPC with a big XML payload) -- PHP is very memory
> inefficient as it will hold the whole POST data into memory and duplicate=
 it
> twice (from SG(request_info).post_data to $HTTP_RAW_POST_DATA -- even if
> always_populate_raw_post_data=3D0 -- and SG(request_info).raw_post_data).
>
> This introduces a new ini setting, disable_post_data_processing, but it's=
 a
> benign one. No incompatibilities between setups will arise because no one
> will enable it globally (it would be insane), only selectively to the
> scripts that require it. The reason for an ini setting is that it must be
> set early in the request life.
>
> Thoughts?
>
> This is a very, very good idea as more and more requests will be in
non-urlencoded format (e.g.: JSON), especially in REST architectures. A
little performance boost would not do any harm.

+1.

> --
> Gustavo Lopes
> --
> PHP Internals - PHP Runtime Development Mailing List
> To unsubscribe, visit: http://www.php.net/unsub.php
>



--=20
Nicolas A. B=E9rard-Nault (nicobn@gmail.com)

--0016e6dab4df3959c40496d42de7--