Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:50887
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: softfail (pb1.pair.com: domain zend.com does not designate 188.65.64.9 as permitted sender)
Message-ID: <4CFDE2DF.8060801@zend.com>
Date: Tue, 07 Dec 2010 10:31:43 +0300
User-Agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.2.12) Gecko/20101103 Fedora/1.0-0.33.b2pre.fc14 Lightning/1.0b3pre Thunderbird/3.1.6
MIME-Version: 1.0
To: Moriyoshi Koizumi <mozo@mozo.jp>
CC: PHP Internals <internals@lists.php.net>, Andi Gutmans <andi@zend.com>, 
 Zeev Suraski <zeev@zend.com>
References: <4CE537B0.1030607@zend.com> <AANLkTingOkPC3mQCswQ8q1iykbtajVGEfwnF2yvSrfrp@mail.gmail.com> <4CFCBFBB.5000901@zend.com> <AANLkTi=jWSLeZRjmxyS+Ey+XMbf7qYND9-NGRRMD8r_8@mail.gmail.com> <4CFD4E2B.5080108@zend.com> <AANLkTim2hkxPUHiay+77bQ4mZOgh-scj05pJi3DC6SGC@mail.gmail.com>
In-Reply-To: <AANLkTim2hkxPUHiay+77bQ4mZOgh-scj05pJi3DC6SGC@mail.gmail.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: --enable-zend-multibyte
From: dmitry@zend.com (Dmitry Stogov)

On 12/07/2010 03:32 AM, Moriyoshi Koizumi wrote:
> On Tue, Dec 7, 2010 at 5:57 AM, Dmitry Stogov<dmitry@zend.com>  wrote:
>> On 12/06/2010 08:25 PM, Moriyoshi Koizumi wrote:
>>>
>>> On Mon, Dec 6, 2010 at 7:49 PM, Dmitry Stogov<dmitry@zend.com>    wrote:
>>>>
>>>> Hi Moriyoshi,
>>>>
>>>> On 12/06/2010 01:31 PM, Moriyoshi Koizumi wrote:
>>>>>
>>>>> Hi,
>>>>>
>>>>> How about using the value of mbstring.script_encoding to determine
>>>>> whether to enable the encoding conversion feature?  If the value is
>>>>> the same as that of mbstring.internal_encoding, then no conversion
>>>>> should be needed in the first place.  Besides we can define some
>>>>> singular value like "none" that completely disables the conversion.
>>>>
>>>> Right now I introduced zend.multibyte directive which enables to look
>>>> into
>>>> mbstring.script_encoding and mbstring.internal_encoding as it did before
>>>> with --enable-zend-multibyte. Note that we can't check for them in ZE
>>>> directly because ZE knows nothing about ext/mbstring. It may be not
>>>> compiled
>>>> into PHP or compiled as DSO. Probably it's possible to do through
>>>> additional
>>>> callbacks.
>>>
>>> Indeed mbstring.script_encoding is only used by zend_multibyte, so it
>>> would make sense to alter the name of the ini setting to something
>>> like zend.script_encoding, and move the relevant part of mbstring.c
>>> into zend_multibyte.c
>>>
>>
>> Usage of zend.script_encoding instead of zend.multibyte might make sense.
>> I'll take a look into it. However I don't see a way to move "the relevant
>> parts" of ext/mbstring into zend_multibute.c. zend_multibyte will have to
>> call for external detector and converter anyway. May be I misunderstood you.
>> Could you explain what you means?
>
> I meant the part only related to the ini setting.  Related part in
> mb_get_info() can be removed as it would no longer belong to mbstring
> settings.  While I am not sure of what you meant by external detector
> and converter, encoding detector would be supplied through
> zend_multibyte_set_functions() in mbstring's MINIT and there should be
> no need to bring any extra facility into zend_multibyte.c .

OK. then we have the same view. I'll take a look how it's easy to move 
zend.script_encoding into ZE.

Thanks. Dmitry.

> Regards,
> Moriyoshi
>
>> Thanks. Dmitry.
>>
>> Thanks. Dmitry.
>>
>>
>>