Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:50850
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.215.45 as permitted sender)
DomainKey-Status: bad
DomainKey-Signature: a=rsa-sha1; c=nofws;
        d=gmail.com; s=gamma;
        h=mime-version:in-reply-to:references:date:message-id:subject:from:to
         :cc:content-type;
        b=bvdFVv14hGYXkNmhmgifvY9T/bcnz7jLf86ceTv2nkZICPNo2s1jkwgRfgeSmD8cQ0
         TuSCen5cp1pbCpAL31vDO3ko+fv4byaT4WA6s3Ljkk2ismjSJm2hL+XbGj0Kg2e3SpYb
         I9EQbh81XoZiHsIoQSvufkV1NsH6/PWUt8hpg=
MIME-Version: 1.0
In-Reply-To: <20101205104251.3e0310d5@benny-pc>
References: <f9e85836d9f401e78d6a045116c6f5e0@beberlei.de>
	<201012050255.54059.larry@garfieldtech.com>
	<20101205104251.3e0310d5@benny-pc>
Date: Sun, 5 Dec 2010 08:18:46 -0800
Message-ID: <AANLkTi=_PyesTufmF=bJr5ZVEqHzTwjbQv3w+kn7j0Yj@mail.gmail.com>
To: Benjamin Eberlei <kontakt@beberlei.de>
Cc: Larry Garfield <larry@garfieldtech.com>, internals@lists.php.net
Content-Type: text/plain; charset=UTF-8
Subject: Re: [PHP-DEV] Patch: Marking DateTime Instances Immutable
From: hermanradtke@gmail.com (Herman Radtke)

> You don't need to know if the instance is immutable or not, since the current DateTime instances also return themselves for method chaining. So any code that looks like:
>
> $d = $d->modify("+1 hour");
>
> would work no matter mutable/immutable. This is still a bit strange though. But still any DateTimeValue would extend DateTime. So when you typehint
> for a "DateTime", you still don't know if you get the one or the other and you would have to resort to the previous code example anyways.

I do need to know if the instance is immutable.  I have plenty of
class methods that modify the DateTime instance and some don't return
the DateTime instance back.  If you want to make sure the object is
immutable, you typehint for a DateTimeValue object.  From an OO
perspective, it makes much more sense to extend the class and add this
functionality than to change the inner workings of the existing class.

-- 
Herman Radtke
hermanradtke@gmail.com | http://hermanradtke.com