Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:5081 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 79576 invoked by uid 1010); 29 Oct 2003 21:15:02 -0000 Delivered-To: ezmlm-scan-internals@lists.php.net Delivered-To: ezmlm-internals@lists.php.net Received: (qmail 79518 invoked from network); 29 Oct 2003 21:15:00 -0000 Received: from unknown (HELO mail.zend.com) (192.117.235.230) by pb1.pair.com with SMTP; 29 Oct 2003 21:15:00 -0000 Received: (qmail 26954 invoked from network); 29 Oct 2003 21:14:52 -0000 Received: from guardian.zend.office (HELO andi-laptop.zend.com) (10.1.1.4) by int.zend.com with SMTP; 29 Oct 2003 21:14:52 -0000 Message-ID: <5.1.0.14.2.20031029231225.02bd1808@127.0.0.1> X-Sender: andi@127.0.0.1 X-Mailer: QUALCOMM Windows Eudora Version 5.1 Date: Wed, 29 Oct 2003 23:12:46 +0200 To: "Pete Dishman" ,internals@lists.php.net In-Reply-To: <20031029153742.77107.qmail@pb1.pair.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii"; format=flowed Subject: Re: [PHP-DEV] BUG #18630 From: andi@zend.com (Andi Gutmans) References: <20031029153742.77107.qmail@pb1.pair.com> Hey, I might have fixed this. Can you please check the latest CVS and let me know if it works for you? Thanks, Andi At 03:36 PM 10/29/2003 +0000, Pete Dishman wrote: >Hi, > >The fact that require_once()/include_once() are case-sensitive on Windows >was reported in bug 18630 http://bugs.php.net/bug.php?id=18630 , however the >bug was then just closed as a documentation problem and nothing was changed, >which is why I'm sending this here rather than adding to the bug report. > >Anyway, on systems with case-insensitive file systems this problem >effectively makes require_once() useless and means you have to rely on code >blocks such as: >if (defined("ASRD_INCLUDED")) > return; >define("ASRD_INCLUDED", TRUE); > >at the top of every single include file, this is definitely ugly and would >be much better replaced by require_once(). >Also using this to prevent multiple inclusions still means that the file >will be parsed multiple times which is an unnecessary performance drain. > > >From what I can tell of the code in zend_execute.c, fixing this bug is just >a matter of taking a copy of the filename and making it lowercase on windows >systems before adding it to the EG(included_files) hashtable. > >Is there any chance this could be fixed before 4.3.4 is released, as it is >definitely a bug and not a documentation problem. > > >Cheers, >Pete Dishman > >------------------------------------------------ > >Peter Dishman > >Software Engineer > >Email: peterd@telephonetics.co.uk > >Address: Telephonetics, Hamilton House, 111 Marlowes, Hemel Hempstead, >Herts. HP1 1BB >+44 (0)1442 242 242 Telephonetics - Making Sound Business Sense - >www.telephonetics.co.uk > >Telephonetics ContactPortal (R) available now : >www.telephonetics.co.uk/products/product_contactportal.html >Intelligent call routing by spoken voice - just say the name and it dials >for you. Call me on 01442 242 242 to hear it in action. > >Arrange flower delivery via local florists using the Telephonetics / Web >Florist service on 08450 111 111 www.webflorists.co.uk/find_a_florist.htm >Prompt service anywhere in the UK. > >The disclaimer available at www.telephonetics.co.uk/edisc.html or by sending >email >to > >-- >PHP Internals - PHP Runtime Development Mailing List >To unsubscribe, visit: http://www.php.net/unsub.php