Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:50708
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain me.com designates 17.148.16.104 as permitted sender)
MIME-version: 1.0
Content-type: text/plain; charset=iso-8859-1
In-reply-to: <AANLkTi=cEhU4nSAOLKYFoicZ2B1aqbR=-TETK5HFeX+j@mail.gmail.com>
Date: Mon, 29 Nov 2010 21:47:39 +0100
Content-transfer-encoding: quoted-printable
Message-ID: <B525AF33-2268-41CE-99A2-883482CE540C@me.com>
References: <ae7aa0536c47a2ac725222d49918183f.squirrel@webmail.basnetworks.net>
 <AANLkTi=wY_djZ=4ZKW7sV4zKpr_X_uEo3iqkA+pSDCsy@mail.gmail.com>
 <4CF3B903.6000204@gmail.com>
 <AANLkTi=cEhU4nSAOLKYFoicZ2B1aqbR=-TETK5HFeX+j@mail.gmail.com>
To: internals@lists.php.net
Subject: Re: [PHP-DEV] RFC: C-sharp style property get/set syntax for PHP
From: dubois.benjamin@me.com (Benjamin Dubois)

Hi !

This is my first email here (I'm just a PHP user, with only very basic C =
skills, but I'm working on it), and I would love to contribute to this =
project.

I have been working with Objective-c lately, and it has a very flexible =
and short way to deal with properties, which could look like this in PHP =
:=20

<?php
class TimePeriod {
	protected $seconds;
	protected $minutes;
	protected $hours;


	@synthesize (readwrite) $hours,  $minutes;
	@synthesize (readonly) $seconds;
}

NB : I intentionally skipped the @property declaration wich I believe is =
a specific need for objc (used to allow dot syntax usage).


In objc, this notation allows to :=20

- use dot syntax for accessing properties (using their getters/setters =
only, all properties are protected in objc)
- write your own getters/setters (only the missing ones are generated)


In Php, the pros of this syntax would be :=20

- very concise
- no interference with existing code (except certain conditions)
- allows to override generated getters and setters with custom code
- may work with the existing code base

The cons :=20

- new syntax to learn (even if it is quite simple)
- need to use pre-determined setters and getters names to keep =
simplicity, which could potentially lead to BC break in some (hopefully =
rare) cases.


What do you think about it ?


Regards,=20

Benjamin
=20



Le 29 nov. 2010 =E0 17:10, Richard Quadling a =E9crit :

> 2010/11/29 =C1ngel Gonz=E1lez <keisial@gmail.com>:
>> Richard Quadling wrote:
>> setMilliseconds() should have $value as parameter instead of a magic =
name.
>>=20
>> What about allowing this syntax to attach the property to a variable?
>>=20
>> For instance:
>>=20
>> <?php
>> class TimePeriod
>> {
>>    protected $seconds;
>>    protected $minutes;
>>    protected $hours;
>>=20
>>    public property Seconds read $seconds write setSeconds;
>>    public property Minutes read $seconds write setMinutes;
>>    public property Hours read $seconds write setHours;
>>=20
>>    public function setSeconds($seconds)
>>    {
>>        if ($seconds >=3D 0 && $seconds < 60) $this->seconds =3D =
$seconds;
>>    }
>>=20
>>    public function setMinutes($minutes)
>>    {
>>        if ($minutes >=3D 0 && $minutes < 60) $this->minutes =3D =
$minutes;
>>    }
>>=20
>>    public function setHours($hours)
>>    {
>>        if ($hours >=3D 0 && $hours < 24) $this->hours =3D $hours;
>>    }
>>=20
>> }
>>=20
>> We only want to perform checks on write, so instead of writing the =
trivial
>> getters, the property is set to the variable itself. Child classes =
could
>> reattach it to a function if needing more control.
>=20
> Ouch. I messed up on the example code. Completely forget that there
> was a parameter to process...
>=20
> As for reading $seconds directly ...
>=20
> Well.
>=20
> If you think of the element that follows read as $this->xxxx, then if
> the parser can handle both ...
>=20
> read $seconds
> read getSeconds
>=20
> then yes for both.
>=20
> If not, then I'd guess that the getSeconds version should be the one
> we use as the value may not actually exist without some processing.
>=20
> Richard.
>=20
> --=20
> Richard Quadling
> Twitter : EE : Zend
> @RQuadling : e-e.com/M_248814.html : bit.ly/9O8vFY
>=20
> --
> PHP Internals - PHP Runtime Development Mailing List
> To unsubscribe, visit: http://www.php.net/unsub.php
>=20