Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:5070
Return-Path: <php-dev@zirzow.dyndns.org>
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Delivered-To: mailing list internals@lists.php.net
Received: (qmail 28058 invoked by uid 1010); 29 Oct 2003 16:07:26 -0000
Delivered-To: ezmlm-scan-internals@lists.php.net
Delivered-To: ezmlm-internals@lists.php.net
Received: (qmail 28014 invoked from network); 29 Oct 2003 16:07:25 -0000
Received: from unknown (HELO bagend.shire) (67.116.86.217)
  by pb1.pair.com with SMTP; 29 Oct 2003 16:07:25 -0000
Received: (qmail 23129 invoked by uid 1000); 29 Oct 2003 16:14:05 -0000
Date: Wed, 29 Oct 2003 16:14:05 +0000
To: internals@lists.php.net
Message-ID: <20031029161405.GK12485@bagend.shire>
Mail-Followup-To: internals@lists.php.net
References: <1067369954.17263.15.camel@lisa.thedoh.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1067369954.17263.15.camel@lisa.thedoh.com>
User-Agent: Mutt/1.4.1i
Subject: Re: [PHP-DEV] [PATCH][ZE2] zend_highlight.c <font> change
From: php-dev@zirzow.dyndns.org (Curt Zirzow)

* Thus wrote Lisa Seelye (lisa@gentoo.org):
> Attached is a patch to change the behavior of source highlighting
> functions to use <span style="color"> instead of <font color="color">. 
> This patch also introduces \n and \t when the parser encounters one
> (this change is mainly for readability).

Slight problem with:
  zend_printf("<span style=\"color: %s;\">\n", last_color);

Although it is a much more elegant solution. Some people consider
inline style attributes bad.


Curt
-- 
"I used to think I was indecisive, but now I'm not so sure."