Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:50697
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.212.42 as permitted sender)
DomainKey-Status: bad
DomainKey-Signature: a=rsa-sha1; c=nofws;
        d=gmail.com; s=gamma;
        h=mime-version:reply-to:in-reply-to:references:from:date:message-id
         :subject:to:cc:content-type:content-transfer-encoding;
        b=icuvANQv5qz9q8AHcoVYRy74A9kMAc7ax0dk9muIO2doL/bNkIcEZRy+RGBkWsLIk+
         SQKnVlk03ZjpGcsZ2u6ISpyImK/gSRRgdM3eY4w1H+6g4i48/uaYpUeIy5hyKLF1Cf5T
         tMuge9KnlWrPegAKsvDsQjiG5aWF41iO9jFWc=
MIME-Version: 1.0
Reply-To: RQuadling@googlemail.com
In-Reply-To: <4CF3B903.6000204@gmail.com>
References: <ae7aa0536c47a2ac725222d49918183f.squirrel@webmail.basnetworks.net>
 <AANLkTi=wY_djZ=4ZKW7sV4zKpr_X_uEo3iqkA+pSDCsy@mail.gmail.com> <4CF3B903.6000204@gmail.com>
Date: Mon, 29 Nov 2010 16:10:13 +0000
Message-ID: <AANLkTi=cEhU4nSAOLKYFoicZ2B1aqbR=-TETK5HFeX+j@mail.gmail.com>
To: =?UTF-8?B?w4FuZ2VsIEdvbnrDoWxleg==?= <keisial@gmail.com>
Cc: internals@lists.php.net
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
Subject: Re: [PHP-DEV] RFC: C-sharp style property get/set syntax for PHP
From: rquadling@gmail.com (Richard Quadling)

2010/11/29 =C3=81ngel Gonz=C3=A1lez <keisial@gmail.com>:
> Richard Quadling wrote:
> setMilliseconds() should have $value as parameter instead of a magic name=
.
>
> What about allowing this syntax to attach the property to a variable?
>
> For instance:
>
> <?php
> class TimePeriod
> {
> =C2=A0 =C2=A0protected $seconds;
> =C2=A0 =C2=A0protected $minutes;
> =C2=A0 =C2=A0protected $hours;
>
> =C2=A0 =C2=A0public property Seconds read $seconds write setSeconds;
> =C2=A0 =C2=A0public property Minutes read $seconds write setMinutes;
> =C2=A0 =C2=A0public property Hours read $seconds write setHours;
>
> =C2=A0 =C2=A0public function setSeconds($seconds)
> =C2=A0 =C2=A0{
> =C2=A0 =C2=A0 =C2=A0 =C2=A0if ($seconds >=3D 0 && $seconds < 60) $this->s=
econds =3D $seconds;
> =C2=A0 =C2=A0}
>
> =C2=A0 =C2=A0public function setMinutes($minutes)
> =C2=A0 =C2=A0{
> =C2=A0 =C2=A0 =C2=A0 =C2=A0if ($minutes >=3D 0 && $minutes < 60) $this->m=
inutes =3D $minutes;
> =C2=A0 =C2=A0}
>
> =C2=A0 =C2=A0public function setHours($hours)
> =C2=A0 =C2=A0{
> =C2=A0 =C2=A0 =C2=A0 =C2=A0if ($hours >=3D 0 && $hours < 24) $this->hours=
 =3D $hours;
> =C2=A0 =C2=A0}
>
> }
>
> We only want to perform checks on write, so instead of writing the trivia=
l
> getters, the property is set to the variable itself. Child classes could
> reattach it to a function if needing more control.

Ouch. I messed up on the example code. Completely forget that there
was a parameter to process...

As for reading $seconds directly ...

Well.

If you think of the element that follows read as $this->xxxx, then if
the parser can handle both ...

read $seconds
read getSeconds

then yes for both.

If not, then I'd guess that the getSeconds version should be the one
we use as the value may not actually exist without some processing.

Richard.

--=20
Richard Quadling
Twitter : EE : Zend
@RQuadling : e-e.com/M_248814.html : bit.ly/9O8vFY