Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:5067
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Date: Wed, 29 Oct 2003 16:46:29 +0100 (CET)
To: Pete Dishman <peterd@telephonetics.co.uk>
cc: internals@lists.php.net
In-Reply-To: <20031029153742.77107.qmail@pb1.pair.com>
Message-ID: <Pine.LNX.4.53.0310291643500.16400@jdi.jdimedia.nl>
References: <20031029153742.77107.qmail@pb1.pair.com>
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII
Subject: Re: [PHP-DEV] BUG #18630
From: derick@php.net (Derick Rethans)

On Wed, 29 Oct 2003, Pete Dishman wrote:

> Hi,
> 
> The fact that require_once()/include_once() are case-sensitive on Windows
> was reported in bug 18630 http://bugs.php.net/bug.php?id=18630 , however the
> bug was then just closed as a documentation problem and nothing was changed,
> which is why I'm sending this here rather than adding to the bug report.
> 
> Anyway, on systems with case-insensitive file systems this problem
> effectively makes require_once() useless and means you have to rely on code
> blocks such as:
> if (defined("ASRD_INCLUDED"))
>  return;
> define("ASRD_INCLUDED", TRUE);
> 
> at the top of every single include file, this is definitely ugly and would
> be much better replaced by require_once().
> Also using this to prevent multiple inclusions still means that the file
> will be parsed multiple times which is an unnecessary performance drain.
> 
> >From what I can tell of the code in zend_execute.c, fixing this bug is just
> a matter of taking a copy of the filename and making it lowercase on windows
> systems before adding it to the EG(included_files) hashtable.
> 
> Is there any chance this could be fixed before 4.3.4 is released, as it is
> definitely a bug and not a documentation problem.

How is this a BUG? It's just a feature on windows where you have 
case-insensitive filenames. I fyou want to handle that, just use one 
style in your code (ie, always lower case).

About your sig:

"I wonder if I could request that you ditch the ridiculous ten-line
.sig?  If not completely, then at least from this list? It's the ASCII
equivalent of walking out of a public restroom with toilet paper hanging
out of the back of your pants. The longer it is, the sillier you look."

Derick

-- 
"Interpreting what the GPL actually means is a job best left to those
                    that read the future by examining animal entrails."
-------------------------------------------------------------------------
 Derick Rethans                                 http://derickrethans.nl/ 
 International PHP Magazine                          http://php-mag.net/
-------------------------------------------------------------------------