Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:50570 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 45825 invoked from network); 25 Nov 2010 19:11:42 -0000 Received: from unknown (HELO lists.php.net) (127.0.0.1) by localhost with SMTP; 25 Nov 2010 19:11:42 -0000 Authentication-Results: pb1.pair.com header.from=johannes@schlueters.de; sender-id=unknown Authentication-Results: pb1.pair.com smtp.mail=johannes@schlueters.de; spf=permerror; sender-id=unknown Received-SPF: error (pb1.pair.com: domain schlueters.de from 217.114.211.66 cause and error) X-PHP-List-Original-Sender: johannes@schlueters.de X-Host-Fingerprint: 217.114.211.66 ns.km36107.keymachine.de Solaris 10 (beta) Received: from [217.114.211.66] ([217.114.211.66:39176] helo=config.schlueters.de) by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP id 78/2C-16484-DE4BEEC4 for ; Thu, 25 Nov 2010 14:11:42 -0500 Received: from [192.168.1.29] (ppp-93-104-60-3.dynamic.mnet-online.de [93.104.60.3]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by config.schlueters.de (Postfix) with ESMTPSA id 7332846909; Thu, 25 Nov 2010 20:11:37 +0100 (CET) To: Rasmus Lerdorf Cc: Ilia Alshanetsky , Andi Gutmans , Jani Taskinen , davey@php.net, PHP Internals In-Reply-To: <4CEEAA2C.2080308@lerdorf.com> References: <73.C4.59959.876BBEC4@pb1.pair.com> <3EA67EA2-A9B1-4DFB-8A30-05B37BCA313B@iki.fi> <8757232E56758B42B2EE4F9D2CA019C9154B70@US-EX2.zend.net> <1290705653.7033.73.camel@guybrush> <4CEE9C5F.3040206@lerdorf.com> <4CEEAA2C.2080308@lerdorf.com> Content-Type: text/plain; charset="UTF-8" Date: Thu, 25 Nov 2010 20:11:35 +0100 Message-ID: <1290712295.7033.201.camel@guybrush> Mime-Version: 1.0 X-Mailer: Evolution 2.30.2 Content-Transfer-Encoding: 7bit Subject: Re: [PHP-DEV] Re: Hold off 5.4 From: johannes@schlueters.de (Johannes =?ISO-8859-1?Q?Schl=FCter?=) On Thu, 2010-11-25 at 10:25 -0800, Rasmus Lerdorf wrote: > We also need that non-null zend_parse_parameters type implemented to > clean up the null-byte poisoning fixes in 5.3. Recently there was an off-list discussion about adding support for accepting non-empty strings only via zend_parse_parameters (zpp). There I raised the concern that we shouldn't add too many special validations for two main reasons: a) The more options zpp has the harder it is to use/read/maintain b) Errors from zpp usually are typically caused by program errors which in other languages for instance might be detected by a compiler not for being bad values as such errors might require different handling by the user. The null-byte thing is not only good for file operations but also for ereg and other places. But we should be sure about the error semantics caused. johannes