Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:50569 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 42342 invoked from network); 25 Nov 2010 19:05:37 -0000 Received: from unknown (HELO lists.php.net) (127.0.0.1) by localhost with SMTP; 25 Nov 2010 19:05:37 -0000 Authentication-Results: pb1.pair.com smtp.mail=rasmus@lerdorf.com; spf=permerror; sender-id=unknown Authentication-Results: pb1.pair.com header.from=rasmus@lerdorf.com; sender-id=unknown Received-SPF: error (pb1.pair.com: domain lerdorf.com from 209.85.160.42 cause and error) X-PHP-List-Original-Sender: rasmus@lerdorf.com X-Host-Fingerprint: 209.85.160.42 mail-pw0-f42.google.com Received: from [209.85.160.42] ([209.85.160.42:61856] helo=mail-pw0-f42.google.com) by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP id 09/7B-16484-083BEEC4 for ; Thu, 25 Nov 2010 14:05:37 -0500 Received: by pwj5 with SMTP id 5so334268pwj.29 for ; Thu, 25 Nov 2010 11:05:33 -0800 (PST) Received: by 10.142.215.16 with SMTP id n16mr1303077wfg.288.1290711933594; Thu, 25 Nov 2010 11:05:33 -0800 (PST) Received: from Anonymous.local (c-98-234-184-167.hsd1.ca.comcast.net [98.234.184.167]) by mx.google.com with ESMTPS id x18sm1327916wfa.23.2010.11.25.11.05.32 (version=TLSv1/SSLv3 cipher=RC4-MD5); Thu, 25 Nov 2010 11:05:32 -0800 (PST) Message-ID: <4CEEB37A.70408@lerdorf.com> Date: Thu, 25 Nov 2010 11:05:30 -0800 User-Agent: Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.6; en-US; rv:1.9.2.12) Gecko/20101027 Lightning/1.0b2 Thunderbird/3.1.6 MIME-Version: 1.0 To: Pierre Joye CC: Andi Gutmans , PHP Internals References: <73.C4.59959.876BBEC4@pb1.pair.com> <3EA67EA2-A9B1-4DFB-8A30-05B37BCA313B@iki.fi> <8757232E56758B42B2EE4F9D2CA019C9154B70@US-EX2.zend.net> <1290705653.7033.73.camel@guybrush> <4CEE9C5F.3040206@lerdorf.com> <4CEEAA2C.2080308@lerdorf.com> <8757232E56758B42B2EE4F9D2CA019C9154E82@US-EX2.zend.net> <4CEEB07E.4050004@lerdorf.com> In-Reply-To: X-Enigmail-Version: 1.1.1 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Subject: Re: [PHP-DEV] Re: Hold off 5.4 From: rasmus@lerdorf.com (Rasmus Lerdorf) On 11/25/10 11:01 AM, Pierre Joye wrote: > I noticed it where functions accepts a path, do some checks (exists, > writable, etc.), resolves paths, etc. and then similar ops are done > again in a couple of places before we call the low level functions, > like in stream, tsrm for example, or extension using other extension's > streams. > > The idea is that file.absolute_path, file.original_path, or > file.resolved_path (example member names) will be passed to the low > level APIs, where each of them have been checked for NULL as well. Do you have an example? Also, these checks are going to hit the stat cache, so I don't think there is much to gain here. -R