Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:50564
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.161.42 as permitted sender)
DomainKey-Status: bad
DomainKey-Signature: a=rsa-sha1; c=nofws;
        d=gmail.com; s=gamma;
        h=mime-version:in-reply-to:references:date:message-id:subject:from:to
         :cc:content-type:content-transfer-encoding;
        b=MHNjthSwWnc72fg93wqY6slQwVtlxGaunoBcZdihiZT+RTCx0xfam9RfIj9qvSXXh4
         Nvf0Hv+uqscIwyLioD5OAlwYLrZTMcRewWl8JtXk7WRbXJ3Ptd0UM4ThcgTo01FyXhvz
         YFKBKYvn7LIF1ikNejPB8Rfs8eCvldVPBSRzI=
MIME-Version: 1.0
In-Reply-To: <8757232E56758B42B2EE4F9D2CA019C9154E82@US-EX2.zend.net>
References: <AANLkTi=coWEEMNnr_SsTCo7HaXUPRwcJg7fUz=NjA8nq@mail.gmail.com>
	<73.C4.59959.876BBEC4@pb1.pair.com>
	<AANLkTikhwbTvpNeW6tufCy=cJzDN3zxaZWtyJPeFEvc=@mail.gmail.com>
	<EBD83EAA-18C4-4F0D-ABE3-C2F8D127FBF3@php.net>
	<3EA67EA2-A9B1-4DFB-8A30-05B37BCA313B@iki.fi>
	<8757232E56758B42B2EE4F9D2CA019C9154B70@US-EX2.zend.net>
	<1290705653.7033.73.camel@guybrush>
	<4CEE9C5F.3040206@lerdorf.com>
	<AANLkTinmQ7a2csTiBPvnZXW_fLbqPNSJm4SzTtZGuBSU@mail.gmail.com>
	<4CEEAA2C.2080308@lerdorf.com>
	<8757232E56758B42B2EE4F9D2CA019C9154E82@US-EX2.zend.net>
Date: Thu, 25 Nov 2010 19:43:10 +0100
Message-ID: <AANLkTik32p6VsK8TXHNKJjGT3gDsvrviw6cGNeHR5RpE@mail.gmail.com>
To: Andi Gutmans <andi@zend.com>
Cc: Rasmus Lerdorf <rasmus@lerdorf.com>, Ilia Alshanetsky <ilia@prohost.org>, 
	=?ISO-8859-1?Q?Johannes_Schl=FCter?= <johannes@schlueters.de>, 
	Jani Taskinen <jani.taskinen@iki.fi>, "davey@php.net" <davey@php.net>, 
	PHP Internals <internals@lists.php.net>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: quoted-printable
Subject: Re: [PHP-DEV] Re: Hold off 5.4
From: pierre.php@gmail.com (Pierre Joye)

On Thu, Nov 25, 2010 at 7:33 PM, Andi Gutmans <andi@zend.com> wrote:
>> -----Original Message-----
>> From: Rasmus Lerdorf [mailto:rasmus@lerdorf.com]
>> Sent: Thursday, November 25, 2010 10:26 AM
>> To: Ilia Alshanetsky
>> Cc: Johannes Schl=FCter; Andi Gutmans; Jani Taskinen; davey@php.net; PHP
>> Internals
>> Subject: Re: [PHP-DEV] Re: Hold off 5.4
>>
>> We also need that non-null zend_parse_parameters type implemented to cle=
an
>> up the null-byte poisoning fixes in 5.3. =A0I can't see this slowing us =
down much as
>> it is pretty trivial. =A0Just takes someone to sit down for a couple of =
hours and
>> implementing it and finding all the places where parameters end up in pa=
ths.
>> There are probably other places we don't want nulls either that currentl=
y have
>> local checks that can be removed.
>
> Yes I agree. We may be able to skip this check for interned strings which=
 would be nice and potentially eliminate performance impact somewhat but it=
's something that would need to be looked into. It's non-trivial but doable=
 (need to add a flag for interned strings whether they have a zero byte or =
not).

What do you think about a path argument? Returning something like
zend_file_handle with some more meta info. Doing so will let us pass
all the way down to the actual file API system call without having to
duplicate opearions (stat, perms, etc.) as each ops will simply set
the member accordingly.

Cheers,
--=20
Pierre

@pierrejoye | http://blog.thepimp.net | http://www.libgd.org