Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:50563 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 32811 invoked from network); 25 Nov 2010 18:33:51 -0000 Received: from unknown (HELO lists.php.net) (127.0.0.1) by localhost with SMTP; 25 Nov 2010 18:33:51 -0000 Authentication-Results: pb1.pair.com smtp.mail=andi@zend.com; spf=pass; sender-id=pass Authentication-Results: pb1.pair.com header.from=andi@zend.com; sender-id=pass Received-SPF: pass (pb1.pair.com: domain zend.com designates 63.205.162.117 as permitted sender) X-PHP-List-Original-Sender: andi@zend.com X-Host-Fingerprint: 63.205.162.117 us-mr1.zend.com Received: from [63.205.162.117] ([63.205.162.117:52101] helo=us-mr1.zend.com) by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP id FF/A9-16484-E0CAEEC4 for ; Thu, 25 Nov 2010 13:33:51 -0500 Received: from us-gw1.zend.com (unknown [192.168.16.15]) by us-mr1.zend.com (Postfix) with ESMTP id BDD632DD5A; Thu, 25 Nov 2010 11:21:58 -0800 (PST) Received: from US-EX2.zend.net ([fe80::9c09:d53f:7b4:5880]) by US-EX2.zend.net ([fe80::1d86:6a3c:13cc:f3a7%11]) with mapi; Thu, 25 Nov 2010 10:33:48 -0800 To: Rasmus Lerdorf , Ilia Alshanetsky CC: =?iso-8859-1?Q?Johannes_Schl=FCter?= , Jani Taskinen , "davey@php.net" , PHP Internals Thread-Topic: [PHP-DEV] Re: Hold off 5.4 Thread-Index: AQHLiwv0eVVQAPlzPU2anLu7uixZU5OB8HOAgABg/ACAABLxAIAAC28ggACKboCAAAGwgIAABP6AgAALdgD//3uZEA== Date: Thu, 25 Nov 2010 18:33:38 +0000 Message-ID: <8757232E56758B42B2EE4F9D2CA019C9154E82@US-EX2.zend.net> References: <73.C4.59959.876BBEC4@pb1.pair.com> <3EA67EA2-A9B1-4DFB-8A30-05B37BCA313B@iki.fi> <8757232E56758B42B2EE4F9D2CA019C9154B70@US-EX2.zend.net> <1290705653.7033.73.camel@guybrush> <4CEE9C5F.3040206@lerdorf.com> <4CEEAA2C.2080308@lerdorf.com> In-Reply-To: <4CEEAA2C.2080308@lerdorf.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: RE: [PHP-DEV] Re: Hold off 5.4 From: andi@zend.com (Andi Gutmans) > -----Original Message----- > From: Rasmus Lerdorf [mailto:rasmus@lerdorf.com] > Sent: Thursday, November 25, 2010 10:26 AM > To: Ilia Alshanetsky > Cc: Johannes Schl=FCter; Andi Gutmans; Jani Taskinen; davey@php.net; PHP > Internals > Subject: Re: [PHP-DEV] Re: Hold off 5.4 >=20 > We also need that non-null zend_parse_parameters type implemented to clea= n > up the null-byte poisoning fixes in 5.3. I can't see this slowing us dow= n much as > it is pretty trivial. Just takes someone to sit down for a couple of hou= rs and > implementing it and finding all the places where parameters end up in pat= hs. > There are probably other places we don't want nulls either that currently= have > local checks that can be removed. Yes I agree. We may be able to skip this check for interned strings which w= ould be nice and potentially eliminate performance impact somewhat but it's= something that would need to be looked into. It's non-trivial but doable (= need to add a flag for interned strings whether they have a zero byte or no= t). Andi