Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:5053
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
To: GPHemsley@aol.com
Cc: internals@lists.php.net
In-Reply-To: <42.400c2e2d.2cd02748@aol.com>
References: <42.400c2e2d.2cd02748@aol.com>
Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="=-SnzYisFhikV7tRiYQbeI"
Message-ID: <1067380170.17388.15.camel@lisa.thedoh.com>
Mime-Version: 1.0
Date: Tue, 28 Oct 2003 17:29:30 -0500
Subject: Re: [PHP-DEV] [PATCH][ZE2] zend_highlight.c <font> change
From: lisa@gentoo.org (Lisa Seelye)

--=-SnzYisFhikV7tRiYQbeI
Content-Type: text/plain
Content-Transfer-Encoding: quoted-printable

On Tue, 2003-10-28 at 15:10, GPHemsley@aol.com wrote:
> In your diff, you have this line: + zend_printf("<span style=3D\"color:
> %s\";>\n", last_color);
> =20
> There's a semicolon (;) in the <span> tag (marked in red, if
> available). If that was meant to be part of the style attribute (like
> style=3D\"color: %s;\">), then it is in the wrong place. And also, if
> that is the place it's supposed to be, then you missed one on
> the +    zend_printf("<span style=3D\"color: %s\">", last_color); line.

Yes quite right on missing the last semicolon.

Truly having it there or not is personal preference.  My preference is
to use semicolons at the end of each style definition, but since in this
context the user can't add any additional styles then it makes sense to
omit it.

--=20
Regards,
-Lisa
<Vix ulla tam iniqua pax, quin bello vel aequissimo sit potior>

--=-SnzYisFhikV7tRiYQbeI
Content-Type: application/pgp-signature; name=signature.asc
Content-Description: This is a digitally signed message part

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.3 (GNU/Linux)

iD8DBQA/nu3Ky0a1Vh5Jb8URAglKAJ4ja/PBzLCUVndy3/yMC+LZqPTv5QCdEufz
2/dB7iwxkHAdIBLC77TQpt8=
=KcOW
-----END PGP SIGNATURE-----

--=-SnzYisFhikV7tRiYQbeI--