Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:5048 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 80221 invoked by uid 1010); 28 Oct 2003 20:11:20 -0000 Delivered-To: ezmlm-scan-internals@lists.php.net Delivered-To: ezmlm-internals@lists.php.net Received: (qmail 80186 invoked from network); 28 Oct 2003 20:11:19 -0000 Received: from unknown (HELO imo-r02.mx.aol.com) (152.163.225.98) by pb1.pair.com with SMTP; 28 Oct 2003 20:11:19 -0000 Received: from GPHemsley@aol.com by imo-r02.mx.aol.com (mail_out_v36_r1.1.) id 1.42.400c2e2d (1320); Tue, 28 Oct 2003 15:10:48 -0500 (EST) Message-ID: <42.400c2e2d.2cd02748@aol.com> Date: Tue, 28 Oct 2003 15:10:48 EST To: lisa@gentoo.org, internals@lists.php.net MIME-Version: 1.0 Content-Type: multipart/alternative; boundary="-----------------------------1067371848" X-Mailer: 9.0 for Windows sub 531 Subject: Re: [PHP-DEV] [PATCH][ZE2] zend_highlight.c change From: GPHemsley@aol.com -------------------------------1067371848 Content-Type: text/plain; charset="US-ASCII" Content-Transfer-Encoding: 7bit In your diff, you have this line: + zend_printf("\n", last_color); There's a semicolon (;) in the tag (marked in red, if available). If that was meant to be part of the style attribute (like style=\"color: %s;\">), then it is in the wrong place. And also, if that is the place it's supposed to be, then you missed one on the + zend_printf("", last_color); line. If I'm wrong, forgive me. Sincerely, Gordon Hemsley -------------------------------1067371848--