Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:50432 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 71366 invoked from network); 23 Nov 2010 10:47:12 -0000 Received: from unknown (HELO lists.php.net) (127.0.0.1) by localhost with SMTP; 23 Nov 2010 10:47:12 -0000 Authentication-Results: pb1.pair.com header.from=dmitry@zend.com; sender-id=pass Authentication-Results: pb1.pair.com smtp.mail=dmitry@zend.com; spf=pass; sender-id=pass Received-SPF: pass (pb1.pair.com: domain zend.com designates 212.25.124.185 as permitted sender) X-PHP-List-Original-Sender: dmitry@zend.com X-Host-Fingerprint: 212.25.124.185 il-mr1.zend.com Received: from [212.25.124.185] ([212.25.124.185:60090] helo=il-mr1.zend.com) by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP id 51/51-59959-FAB9BEC4 for ; Tue, 23 Nov 2010 05:47:12 -0500 Received: from il-gw1.zend.com (unknown [10.1.1.22]) by il-mr1.zend.com (Postfix) with ESMTP id 11D2F504B6; Tue, 23 Nov 2010 12:41:18 +0200 (IST) Received: from ws.home (10.1.10.20) by il-ex2.zend.net (10.1.1.22) with Microsoft SMTP Server id 14.0.689.0; Tue, 23 Nov 2010 12:46:57 +0200 Message-ID: <4CEB9BA9.7060702@zend.com> Date: Tue, 23 Nov 2010 13:47:05 +0300 User-Agent: Thunderbird 2.0.0.23 (X11/20090825) MIME-Version: 1.0 To: Gustavo Lopes CC: , Christopher Jones , Derick Rethans , Kalle Sommer Nielsen , Zeev Suraski , Andi Gutmans , Moriyoshi Koizumi References: <4CE537B0.1030607@zend.com> <4CE56978.9050102@oracle.com> <4CE686BC.4080307@zend.com> <4CEAECC2.6060403@oracle.com> <4CEB8AB9.4070909@zend.com> In-Reply-To: Content-Type: text/plain; charset="ISO-8859-15"; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [PHP-DEV] --enable-zend-multibyte From: dmitry@zend.com (Dmitry Stogov) Gustavo Lopes wrote: > On Tue, 23 Nov 2010 09:34:49 -0000, Dmitry Stogov wrote: > >> hi, >> >> I've prepared the patch which completely removes compile-time >> --enable-zend-multibyte configuration directive. >> >> The configuration can be changed at run-tume using zend.multibyte=0/1. >> >> The patch also fixes Unicode detection for phar archives. >> >> I would like to commit it on Thursday. >> > > Just two comments: > > * You have a line commented out with // (line #443) > * The phar fix autodetection is wrong. You look for __HALT_COMPILER, but > you should be looking for __HALT_COMPILER();, __halt_compiler(); or any > casing variation. __HALT_COMPILER, by itself, does nothing (see > http://lxr.php.net/opengrok/xref/PHP_TRUNK/Zend/zend_language_parser.y#219 > ). See the patches in #53199. Thank you for comments. I'll care about both issues. Thanks. Dmitry. > Also remember to close #42396 once you commit a proper fix. > > Other than that, no objections. >